Skip to content

Conversation

JyotikaGargg
Copy link
Contributor

#179
When a user specifies following command :
"sqlcmd on-error.sql -b"

In on-error.sql :

:ONERROR ignore

select @@versioNN

GO

select @@Version

GO
Actual Output : It is exiting with error code.
Expected Output : It should run with only printing error message

@shueybubbles
Copy link
Collaborator

pls add a test that fails without this fix

Copy link
Collaborator

@shueybubbles shueybubbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Copy link
Contributor

@apoorvdeshmukh apoorvdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also extend or add a testcase for the issue mentioned in PR?

Copy link
Collaborator

@shueybubbles shueybubbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants