Skip to content

Stub -M and fix !! #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 28, 2022
Merged

Stub -M and fix !! #152

merged 3 commits into from
Oct 28, 2022

Conversation

shueybubbles
Copy link
Collaborator

Customer feedback from a financial services company -
!! shouldn't require a space after it, and -M should just be ignored.

stuartpa
stuartpa reviewed Oct 28, 2022
View reviewed changes
stuartpa
stuartpa approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@stuartpa stuartpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shueybubbles
Copy link
Collaborator Author

Fixes #140

@shueybubbles shueybubbles linked an issue Oct 28, 2022 that may be closed by this pull request
Provide useful HINT to user who passes -P into command line #140
Closed
@shueybubbles shueybubbles merged commit dfa27e0 into main Oct 28, 2022
@shueybubbles shueybubbles deleted the shueybubbles/stubM branch October 28, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartpa stuartpa stuartpa approved these changes

@apoorvdeshmukh apoorvdeshmukh Awaiting requested review from apoorvdeshmukh

@kenvanhyning kenvanhyning Awaiting requested review from kenvanhyning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide useful HINT to user who passes -P into command line
2 participants
@shueybubbles @stuartpa