Modern POSIX style CLI for SQLCMD - Part 2

[stuartpa]

This is the 2nd part for the modern-CLI. See PR165 for first part:

• Modern POSIX style CLI for SQLCMD #165

This PR moves the file-layout for the modern CLI to conform to the idiomatic golang layout, and focuses on test and code coverage, there is no new functionality in this PR. The Unit test coverage for the modern sqlcmd.exe now 95%+.

The formatting of the MIT license file was part of @shueybubbles original commit, I presume we want to keep these.

TODO:

• A follow up PR will at the ./cmd/modern folder (that builds the new sqlcmd.exe) to the build pipelines.
• Right now, three tests are skipped, TestQuery, TestNegUninstallNoInstanceToUninstall and TestUnicodeInput, I am debugging these now

[shueybubbles]

we should commit .editorconfig so everyone gets the same behavior. the go tooling handles most of it ok but if there are options the go tools don't enforce automatically we should use this file for consistency.

---

In reply to: 1279168195

---

In reply to: 1279168195

---

In reply to: 1279168195

---

In reply to: 1279168195

---

Refers to: .gitignore:27 in 3db8294. [](commit_id = 3db8294, deletion_comment = False)

[stuartpa]

Done

---

In reply to: 1279168195

---

Refers to: .gitignore:27 in 3db8294. [](commit_id = 3db8294, deletion_comment = False)

[shueybubbles]

main()

"doesn't panic" seems like a very minimal test. Couldn't this test verify that rootCmd is constructe with proper values?

[shueybubbles]

the structure looks ok to me. I don't see much value in unit tests that exercise a function with no assertions about the behavior. A unit test should serve as a specification (code > English) for a method, but without assertions there's no definition of correct behavior other than "it doesn't panic". With the dependency structure you have established, unit tests should have an easy ability to inject an interface implementation into the dependencies and verify that the method under test utilized that dependency correctly, much the way C# tests do with Moq. That way the unit test establishes the relationship between a given method and its dependencies and can truly prevent regressions in the future.

[shueybubbles]