Choco (Windows) release package #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Otherwise delete. this file. If you are the software author, you can change this | ||
| mention you are the author of the software. | ||
|
|
||
| ===DELETE ABOVE THIS LINE AND THIS LINE=== |
There was a problem hiding this comment.
follow the direction :-)
| $ErrorActionPreference = 'Stop'; | ||
|
|
||
| $toolsDir = "$(Split-Path -parent $MyInvocation.MyCommand.Definition)" | ||
| $url = '{{DownloadUrl}}' |
There was a problem hiding this comment.
where is DownloadUrl defined? Is url unused because we only support 64bit on Windows?
There was a problem hiding this comment.
Yes, I believe so. Should we add support for 32bit as well?
|
|
||
| $toolsDir = "$(Split-Path -parent $MyInvocation.MyCommand.Definition)" | ||
| $url = '{{DownloadUrl}}' | ||
| $url64 = 'https://download.microsoft.com/download/d/4/4/d4403a51-2ab7-4ea8-b850-d2710c5e1323/sqlcmd_0.8.1-1.msi' |
There was a problem hiding this comment.
shouldn't the script take the sqlcmd version as a parameter?
shueybubbles
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chocolatey package manager files, being submitted to choco at:
https://community.chocolatey.org/packages/sqlcmd/0.8.1
This PR won't be merged until we have worked out how to automate this submission in a pipeline