Skip to content

[dev-v5] POC to convert the Calendar and DatePicker to a generic type #4153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 32 commits into
base: dev-v5
Choose a base branch
from
Draft

[dev-v5] POC to convert the Calendar and DatePicker to a generic type #4153

wants to merge 32 commits into from

Conversation

dvoituron
Copy link
Collaborator

[dev-v5] POC to convert the Calendar and DatePicker to a generic type

DRAFT

@dvoituron
Refactor FluentCalendar components to support generic TValue type for…
bf82d2c 
… enhanced flexibility
@dvoituron
Refactoring CalendarTValue convert methods
54276fc
@dvoituron
Refacroring to extension methods
afb9ad9
@dvoituron
Refactored FluentCalendar.razor.cs to use generic type TValue for…
7a3257a 
… selected dates, improving type safety and flexibility.
@dvoituron
Converted PickerDay, PickerMonth, and PickerYear to nullable ty…
cd81cfc 
…pes in `CalendarDefault.razor`.
@dvoituron
Refactor calendar components for nullable date handling
a122b4e 
Updated calendar components to support nullable DateTime values and generic date representations. Key changes include:
- Modified `DisabledDate` methods to accept `DateTime?`.
- Changed `SelectedDay` in `CalendarSelection.razor` to a non-nullable `DateTime`.
- Updated `DisabledDateFunc` in `FluentCalendarBase.cs` to use a generic type `TValue`.
- Refactored `OnSelectedDateHandlerAsync` to accept `TValue`.
- Implemented conversions to `TValue` in various methods for consistency.
- Enhanced `PickerMonthChanged` to handle nullable month values in `FluentDatePicker.razor`.
- Streamlined `OnSelectedDateAsync` to directly use `TValue`.

These changes improve the flexibility and robustness of the calendar components.
@dvoituron
Fix Unit Tests
14670be
@dvoituron
Refactoring
74a44e6
@dvoituron
Refactoring
482d831
@github-actions GitHub Actions
Copy link

Unit Tests

  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.InputBaseTests.InputBase_DefaultProperties(attributeName: "Required", attributeValue: True, htmlAttribute: "required", htmlValue: null, extraCondition: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.ComponentBaseTests.ComponentBase_DefaultProperties(blazor: "extra-attribute='My-Specific-Attribute'", html: "extra-attribute='My-Specific-Attribute'")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.ComponentBaseTests.ComponentBase_DefaultProperties(blazor: "Style='My-Specific-Style'", html: "style='My-Specific-Style'")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentDatePickerTests.FluentDatePicker_Default
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.TryParseValueFromString_ReturnsExpectedResults(input: "invalid-date", expectedSuccess: True, expectedDateString: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.Utilities.FluentCalendarDayTests.IsToday_Property_IsCorrect
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.ComponentBaseTests.ComponentBase_DefaultProperties(blazor: "Padding='10px'", html: "style='padding: 10px;*'")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentDatePickerTests.FluentDatePicker_TryParseValueFromString_DaysView(input: "", expectedResult: True, expectedDateString: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.ComponentBaseTests.ComponentBase_DefaultProperties(blazor: "Id='id='My-Specific-ID'", html: "id='My-Specific-ID'")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.TryParseValueFromString_WithNonGregorianCalendars_UsesCorrectCulture(cultureName: "fa-IR")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.PickerMonthSelectAsync_TriggersPickerMonthChanged
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.InputBaseTests.InputBase_DefaultProperties(attributeName: "Name", attributeValue: "my-name", htmlAttribute: "name", htmlValue: null, extraCondition: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.FluentCalendar_Title_ByCulture(year: 2022, month: 2, day: 15, cultureName: "fa-IR")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.InputBaseTests.InputBase_DefaultProperties(attributeName: "InputSlot", attributeValue: "input", htmlAttribute: null, htmlValue: "slot="input"", extraCondition: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentDatePickerTests.FluentDatePicker_SelectDate(initialDate: "2022-01-15", selectedDate: "2022-01-20", expectedDate: "2022-01-20", openedByKeyboard: False)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentDatePickerTests.FluentDatePicker_TryParseValueFromString_YearsView(input: "", expectedResult: True, expectedDateString: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.InputBaseTests.InputBase_DefaultProperties(attributeName: "LabelWidth", attributeValue: "150px", htmlAttribute: null, htmlValue: "width: 150px;", extraCondition: "Set_LabelPosition_Before")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentDatePickerTests.FluentDatePicker_ClickToOpenCalendar
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.TryParseValueFromString_WithNonGregorianCalendars_UsesCorrectCulture(cultureName: "ar-SA")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.TryParseValueFromString_AlwaysReturnsTrue
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.FluentCalendar_OneDayFormat
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.InputBaseTests.InputBase_DefaultProperties(attributeName: "LabelPosition", attributeValue: Before, htmlAttribute: "label-position", htmlValue: "before", extraCondition: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.InputBaseTests.InputBase_DefaultProperties(attributeName: "ReadOnly", attributeValue: True, htmlAttribute: "readonly", htmlValue: null, extraCondition: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.ComponentBaseTests.ComponentBase_DefaultProperties(blazor: "Margin='10px'", html: "style='margin: 10px;*'")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.FluentCalendar_Title
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.ComponentBaseTests.ComponentBase_DefaultProperties(blazor: "Class='My-Specific-Item'", html: "class='My-Specific-Item'")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.InputBaseTests.InputBase_DefaultProperties(attributeName: "Message", attributeValue: "my-message", htmlAttribute: null, htmlValue: null, extraCondition: "Add_MessageCondition_AlwaysTrue")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentDatePickerTests.FluentDatePicker_TryParseValueFromString_DaysView(input: null, expectedResult: True, expectedDateString: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentDatePickerTests.FluentDatePicker_SelectDate(initialDate: "2022-01-15", selectedDate: "2022-01-20", expectedDate: "2022-01-20", openedByKeyboard: True)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.TryParseValueFromString_AlwaysSetsValidationErrorMessageToNull
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.ComponentBaseTests.ComponentBase_DefaultProperties(blazor: "Padding='my-padding'", html: "class='my-padding'")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentDatePickerTests.FluentDatePicker_TryParseValueFromString_YearsView(input: "invalid", expectedResult: True, expectedDateString: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.InputBaseTests.InputBase_DefaultProperties(attributeName: "AriaLabel", attributeValue: "my-aria-label", htmlAttribute: "aria-label", htmlValue: null, extraCondition: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.FluentCalendar_Title_ByCulture(year: 2022, month: 2, day: 15, cultureName: "en-US")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.FluentCalendar_WeekDays_French
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.InputBaseTests.InputBase_DefaultProperties(attributeName: "LostFocus", attributeValue: "input", htmlAttribute: null, htmlValue: null, extraCondition: "Check_LostFocus")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.Utilities.FluentCalendarDayTests.IsInactive_Property_IsCorrect(isOutsideMonth: False, isInDisabledList: False, expected: False)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.InputBaseTests.InputBase_DefaultProperties(attributeName: "MessageState", attributeValue: Success, htmlAttribute: null, htmlValue: "color: var(--success);", extraCondition: "Add_MessageCondition_AlwaysTrue")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.InputBaseTests.InputBase_DefaultProperties(attributeName: "Label", attributeValue: "my-label", htmlAttribute: null, htmlValue: null, extraCondition: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentDatePickerTests.FluentDatePicker_TryParseValueFromString_DaysView(input: "invalid date", expectedResult: True, expectedDateString: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentDatePickerTests.FluentDatePicker_TryParseValueFromString_YearsView(input: null, expectedResult: True, expectedDateString: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.FluentCalendar_WeekDaysTitle
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.TryParseValueFromString_ReturnsExpectedResults(input: "", expectedSuccess: True, expectedDateString: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.ComponentBaseTests.ComponentBase_DefaultProperties(blazor: "Margin='my-margin'", html: "class='my-margin'")
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.InputBaseTests.InputBase_DefaultProperties(attributeName: "Disabled", attributeValue: True, htmlAttribute: "disabled", htmlValue: null, extraCondition: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.TryParseValueFromString_ReturnsExpectedResults(input: null, expectedSuccess: True, expectedDateString: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.Base.InputBaseTests.InputBase_DefaultProperties(attributeName: "Autofocus", attributeValue: True, htmlAttribute: "autofocus", htmlValue: null, extraCondition: null)
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.PickerMonthSelectAsync_WithDifferentCultures_RespectsCalendar
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentCalendarTests.FluentCalendar_Default
  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Components.DateTimes.FluentDatePickerTests.FluentDatePicker_SelectDate(initialDate: "2022-01-15 10:09:00", selectedDate: "2022-01-20", expectedDate: "2022-01-20 10:09:00", openedByKeyboard: False)

Details on your Workflow / Core Tests page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnbaaij vnbaaij Awaiting requested review from vnbaaij vnbaaij will be requested when the pull request is marked ready for review vnbaaij is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dvoituron