Skip to content

Basic auth asio on Linux #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Basic auth asio on Linux #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3b7165
add support for basic authentication
ritzk Jun 26, 2016
526e997
asio basic auth support: test case
ritzk Jun 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion Release/src/http/client/http_client_asio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,12 @@ class asio_context : public request_context, public std::enable_shared_from_this
{
extra_headers.append(ctx->generate_basic_proxy_auth_header());
}


if (ctx->m_http_client->client_config().credentials().is_set())
{
extra_headers.append(ctx->generate_basic_auth_header());
}

// Check user specified transfer-encoding.
std::string transferencoding;
if (ctx->m_request.headers().match(header_names::transfer_encoding, transferencoding) && transferencoding == "chunked")
Expand Down Expand Up @@ -732,6 +737,23 @@ class asio_context : public request_context, public std::enable_shared_from_this
}

private:
utility::string_t generate_basic_auth_header()
{
utility::string_t header;

header.append(header_names::authorization);
header.append(": Basic ");

auto credential_str = web::details::plaintext_string(new ::utility::string_t(m_http_client->client_config().credentials().username()));
credential_str->append(":");
credential_str->append(*m_http_client->client_config().credentials().decrypt());

std::vector<unsigned char> credentials_buffer(credential_str->begin(), credential_str->end());

header.append(utility::conversions::to_base64(credentials_buffer));
header.append(CRLF);
return header;
}

utility::string_t generate_basic_proxy_auth_header()
{
Expand Down
31 changes: 31 additions & 0 deletions Release/tests/functional/http/client/authentication_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,6 +620,37 @@ TEST_FIXTURE(uri_address, failed_authentication_attempt, "Ignore:Linux", "89", "

#if !defined(_WIN32)

// http_server does not support auth
void auth_test_impl(bool fail)
{
std::string user("user1"), password("user1");
auto return_code = status_codes::NotFound; // return 404 if successful auth

if (fail)
{
password = "invalid";
return_code = status_codes::Unauthorized;
}

http_client_config client_config;
web::credentials cred(U(user), U(password));
client_config.set_credentials(cred);
http_client client(U("http://test.webdav.org/auth-basic/"), client_config);

http_response response = client.request(methods::GET).get();
VERIFY_ARE_EQUAL(return_code, response.status_code());
}

TEST(auth_no_data)
{
auth_test_impl(false);
}

TEST(unsuccessful_auth_with_basic_cred)
{
auth_test_impl(true);
}

TEST_FIXTURE(uri_address, set_user_options_asio_http)
{
test_http_server::scoped_server scoped(m_uri);
Expand Down