Skip to content

Conversation

rinopazzo
Copy link

Added "-Wno-error" and "-Wno-unused-local-typedefs" to the clang suppression list into Release/CMakeLists.xtx. It solves build problems on iOS.

Without this options the build process on iOS fails.

…ression list. It solves build problems on iOS.
@msftclas
Copy link

Hi @rinopazzo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the -Wno-error? Do we have any other warning causing build failures? It is better to have the warnings cause build failure so we can address the failures appropriately (either by fixing the code or by suppressing the warning consciously).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also is it -Wunused-local-typedef or -Wunused-local-typedefs ?

@rinopazzo
Copy link
Author

It is -Wunused-local-typedefs because -Wunused-local-typedef not works on iOS.

@rinopazzo
Copy link
Author

-Wno-error is not needed, it is a my mistake.

@kavyako
Copy link
Contributor

kavyako commented Dec 3, 2015

Removed the -Wno-error and merged the changes into development branch. Thank you for fixing the build break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants