Skip to content

Don't initialize atomic_flag with 0. #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Don't initialize atomic_flag with 0. #1093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Release/src/pplx/pplx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace details
class _Spin_lock
{
public:
_Spin_lock() : _M_lock(0) {}
_Spin_lock() : _M_lock() {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This compiles, but according to this initializes the flag to an "unspecified state". Perhaps it works in all implementations we care about, but to guarantee it starts unlocked, it says we need to use ATOMIC_FLAG_INIT - or call clear.


void lock()
{
Expand Down