Skip to content

Move Iterable/AsyncIterable into main DOM/WebWorker libs #62111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2025
Merged

Move Iterable/AsyncIterable into main DOM/WebWorker libs #62111

merged 2 commits into from
Oct 2, 2025
+5,266 −5,244

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Jul 23, 2025 •
edited
Loading

Related #54500
Fixes #60959

This PR moves the contents of DOM.Iterable and DOM.AsyncIterable into DOM. DOM now references es2015 and es2018.asynciterable. DOM is now effectively evergreen.

(Same applies to webworker)

TODO:

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 23, 2025
@jakebailey
Copy link
Member Author

@typescript-bot test it
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 23, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
pack this ✅ Started ✅ Results
test top400 ✅ Started 👀 Results
user test this ✅ Started ✅ Results
run dt ✅ Started 👀 Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 23, 2025 •
edited
Loading

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/165729/artifacts?artifactName=tgz&fileId=850BA94CBF29B1799E021F58C6D50FAEA15105D55C1C30A291718B1340BEEDF502&fileName=/typescript-5.9.0-insiders.20250723.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: es6-collections
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/es6-collections/index.d.ts
  16:11  error  TypeScript@local compile error: 
Duplicate identifier 'IteratorResult'                                                                                                                          @definitelytyped/expect
  41:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  47:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  61:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  67:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  83:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  83:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>'  @definitelytyped/expect
  96:23  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  97:47  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  98:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  98:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>'            @definitelytyped/expect

✖ 11 problems (11 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: es6-shim
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/es6-shim/index.d.ts
    1:11  error  TypeScript@local compile error: 
Duplicate identifier 'IteratorResult'                                                                                                                          @definitelytyped/expect
  240:5   error  TypeScript@local compile error: 
All declarations of 'EPSILON' must have identical modifiers                                                                                                    @definitelytyped/expect
  275:5   error  TypeScript@local compile error: 
All declarations of 'MAX_SAFE_INTEGER' must have identical modifiers                                                                                           @definitelytyped/expect
  282:5   error  TypeScript@local compile error: 
All declarations of 'MIN_SAFE_INTEGER' must have identical modifiers                                                                                           @definitelytyped/expect
  338:5   error  TypeScript@local compile error: 
All declarations of 'flags' must have identical modifiers                                                                                                      @definitelytyped/expect
  502:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  567:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  576:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  587:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  597:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  612:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  612:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>'  @definitelytyped/expect
  624:23  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  625:48  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  626:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  626:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>'            @definitelytyped/expect

✖ 16 problems (16 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62111/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,370 62,370 ~ ~ ~ p=1.000 n=6
Types 50,386 50,386 ~ ~ ~ p=1.000 n=6
Memory used 192,994k (± 0.09%) 194,258k (± 0.91%) ~ 192,910k 196,553k p=0.173 n=6
Parse Time 1.31s (± 0.48%) 1.30s (± 0.69%) ~ 1.29s 1.31s p=0.070 n=6
Bind Time 0.73s 0.73s ~ ~ ~ p=1.000 n=6
Check Time 9.73s (± 0.31%) 9.75s (± 0.22%) ~ 9.72s 9.78s p=0.418 n=6
Emit Time 2.74s (± 0.48%) 2.74s (± 1.00%) ~ 2.71s 2.78s p=0.868 n=6
Total Time 14.51s (± 0.16%) 14.52s (± 0.22%) ~ 14.47s 14.55s p=0.570 n=6
angular-1 - node (v18.15.0, x64)
Errors 56 56 ~ ~ ~ p=1.000 n=6
Symbols 948,914 948,717 -197 (- 0.02%) ~ ~ p=0.001 n=6
Types 410,884 410,884 ~ ~ ~ p=1.000 n=6
Memory used 1,226,383k (± 0.00%) 1,226,332k (± 0.00%) ~ 1,226,267k 1,226,372k p=0.128 n=6
Parse Time 6.51s (± 0.49%) 6.52s (± 1.01%) ~ 6.45s 6.62s p=0.872 n=6
Bind Time 1.87s (± 0.28%) 1.88s (± 0.27%) ~ 1.87s 1.88s p=0.311 n=6
Check Time 32.01s (± 0.25%) 32.05s (± 0.54%) ~ 31.84s 32.30s p=0.687 n=6
Emit Time 14.80s (± 0.89%) 14.79s (± 0.41%) ~ 14.70s 14.86s p=0.471 n=6
Total Time 55.20s (± 0.20%) 55.24s (± 0.37%) ~ 54.92s 55.45s p=0.521 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,542,818 2,542,538 -280 (- 0.01%) ~ ~ p=0.001 n=6
Types 900,360 900,360 ~ ~ ~ p=1.000 n=6
Memory used 2,829,317k (± 0.01%) 2,829,140k (± 0.01%) ~ 2,828,874k 2,829,347k p=0.173 n=6
Parse Time 8.74s (± 0.27%) 8.75s (± 0.28%) ~ 8.72s 8.79s p=0.295 n=6
Bind Time 2.25s (± 0.33%) 2.25s (± 0.37%) ~ 2.25s 2.27s p=0.652 n=6
Check Time 85.86s (± 0.43%) 85.86s (± 0.80%) ~ 84.93s 86.97s p=0.810 n=6
Emit Time 1.32s (±84.36%) 0.99s (±96.40%) ~ 0.30s 2.37s p=0.624 n=6
Total Time 98.17s (± 1.15%) 97.87s (± 1.46%) ~ 96.27s 100.07s p=0.575 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,227,048 1,227,048 ~ ~ ~ p=1.000 n=6
Types 267,470 267,470 ~ ~ ~ p=1.000 n=6
Memory used 2,423,932k (± 6.14%) 2,667,832k (±13.45%) ~ 2,362,968k 3,095,006k p=0.173 n=6
Parse Time 5.22s (± 1.09%) 5.27s (± 0.94%) ~ 5.21s 5.33s p=0.128 n=6
Bind Time 1.78s (± 1.36%) 1.78s (± 1.16%) ~ 1.74s 1.80s p=1.000 n=6
Check Time 35.25s (± 0.61%) 35.43s (± 0.83%) ~ 35.05s 35.84s p=0.335 n=6
Emit Time 3.00s (± 0.74%) 2.96s (± 2.03%) ~ 2.86s 3.02s p=0.295 n=6
Total Time 45.27s (± 0.41%) 45.44s (± 0.67%) ~ 45.09s 45.88s p=0.378 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,227,048 1,227,048 ~ ~ ~ p=1.000 n=6
Types 267,470 267,470 ~ ~ ~ p=1.000 n=6
Memory used 2,797,186k (±14.25%) 2,676,014k (±14.05%) ~ 2,431,948k 3,161,939k p=1.000 n=6
Parse Time 6.81s (± 1.38%) 6.76s (± 1.56%) ~ 6.68s 6.92s p=0.575 n=6
Bind Time 2.23s (± 2.58%) 2.20s (± 2.61%) ~ 2.11s 2.26s p=0.377 n=6
Check Time 42.93s (± 1.05%) 42.82s (± 0.54%) ~ 42.55s 43.03s p=0.471 n=6
Emit Time 3.54s (± 2.51%) 3.56s (± 2.92%) ~ 3.45s 3.73s p=0.748 n=6
Total Time 55.50s (± 0.96%) 55.36s (± 0.53%) ~ 54.93s 55.62s p=0.471 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,548 262,548 ~ ~ ~ p=1.000 n=6
Types 107,156 107,156 ~ ~ ~ p=1.000 n=6
Memory used 441,936k (± 0.02%) 441,918k (± 0.02%) ~ 441,804k 441,999k p=0.689 n=6
Parse Time 4.40s (± 1.04%) 4.36s (± 0.43%) ~ 4.33s 4.38s p=0.077 n=6
Bind Time 1.63s (± 0.67%) 1.62s (± 0.50%) ~ 1.61s 1.63s p=0.383 n=6
Check Time 23.46s (± 0.36%) 23.41s (± 0.29%) ~ 23.33s 23.53s p=0.423 n=6
Emit Time 1.91s (± 0.39%) 1.89s (± 1.04%) ~ 1.86s 1.91s p=0.054 n=6
Total Time 31.40s (± 0.39%) 31.28s (± 0.20%) ~ 31.18s 31.35s p=0.149 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 71 71 ~ ~ ~ p=1.000 n=6
Symbols 225,367 225,367 ~ ~ ~ p=1.000 n=6
Types 94,290 94,290 ~ ~ ~ p=1.000 n=6
Memory used 371,134k (± 0.01%) 371,108k (± 0.01%) ~ 371,068k 371,181k p=0.575 n=6
Parse Time 2.90s (± 1.36%) 2.88s (± 0.92%) ~ 2.84s 2.91s p=0.574 n=6
Bind Time 1.60s (± 0.88%) 1.60s (± 1.55%) ~ 1.57s 1.64s p=0.746 n=6
Check Time 16.43s (± 0.36%) 16.46s (± 0.21%) ~ 16.40s 16.50s p=0.520 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 20.92s (± 0.29%) 20.94s (± 0.28%) ~ 20.87s 21.01s p=0.936 n=6
vscode - node (v18.15.0, x64)
Errors 1 1 ~ ~ ~ p=1.000 n=6
Symbols 3,530,678 3,530,396 -282 (- 0.01%) ~ ~ p=0.001 n=6
Types 1,191,846 1,191,846 ~ ~ ~ p=1.000 n=6
Memory used 3,579,300k (± 0.00%) 3,579,141k (± 0.00%) -159k (- 0.00%) 3,579,033k 3,579,203k p=0.013 n=6
Parse Time 15.13s (± 0.46%) 15.21s (± 0.74%) ~ 15.06s 15.35s p=0.192 n=6
Bind Time 4.90s (± 0.29%) 5.14s (±12.65%) ~ 4.86s 6.47s p=0.295 n=6
Check Time 101.02s (± 1.65%) 100.41s (± 4.12%) ~ 95.95s 105.91s p=0.378 n=6
Emit Time 33.05s (±17.79%) 30.63s (± 1.00%) ~ 30.25s 31.00s p=0.689 n=6
Total Time 154.09s (± 4.08%) 151.40s (± 2.53%) ~ 147.85s 156.77s p=0.298 n=6
webpack - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 320,544 321,546 +1,002 (+ 0.31%) ~ ~ p=0.001 n=6
Types 140,017 140,553 +536 (+ 0.38%) ~ ~ p=0.001 n=6
Memory used 476,545k (± 0.04%) 477,783k (± 0.01%) +1,238k (+ 0.26%) 477,692k 477,857k p=0.005 n=6
Parse Time 4.29s (± 0.34%) 4.30s (± 0.61%) ~ 4.26s 4.33s p=0.291 n=6
Bind Time 1.78s (± 1.35%) 1.79s (± 0.76%) ~ 1.78s 1.81s p=0.292 n=6
Check Time 20.56s (± 0.58%) 20.67s (± 0.70%) ~ 20.45s 20.80s p=0.199 n=6
Emit Time 0.00s (±244.70%) 0.00s ~ ~ ~ p=0.405 n=6
Total Time 26.64s (± 0.45%) 26.76s (± 0.55%) ~ 26.57s 26.91s p=0.108 n=6
xstate-main - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 662,663 663,032 +369 (+ 0.06%) ~ ~ p=0.001 n=6
Types 197,635 197,637 +2 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 569,753k (± 0.03%) 570,525k (± 0.03%) +772k (+ 0.14%) 570,334k 570,663k p=0.005 n=6
Parse Time 4.28s (± 0.71%) 4.27s (± 0.65%) ~ 4.23s 4.31s p=0.570 n=6
Bind Time 1.33s (± 1.46%) 1.33s (± 0.78%) ~ 1.31s 1.34s p=0.512 n=6
Check Time 20.03s (± 1.85%) 20.13s (± 1.82%) ~ 19.84s 20.60s p=0.229 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 25.64s (± 1.44%) 25.73s (± 1.54%) ~ 25.41s 26.24s p=0.378 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62111/merge:

Something interesting changed - please have a look.

Details

BuilderIO/mitosis

17 of 25 projects failed to build with the old tsc and were ignored

packages/core/tsconfig.build.json

react-bootstrap/react-bootstrap

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

test/tsconfig.json

@jakebailey jakebailey changed the title Move DOM.Iterable contents to DOM, make DOM reference ES6/ES2015 Move DOM.Iterable/AsyncIterable into DOM Sep 26, 2025
@jakebailey
Copy link
Member Author

@typescript-bot test it
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 26, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
pack this ✅ Started ✅ Results
test top400 ✅ Started 👀 Results
user test this ✅ Started ✅ Results
run dt ✅ Started 👀 Results
perf test this faster ✅ Started 👀 Results

@jakebailey jakebailey mentioned this pull request Sep 26, 2025
Closed
@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 26, 2025 •
edited
Loading

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/166122/artifacts?artifactName=tgz&fileId=7B6A18782044AA0878CE0A4D17063B28412FDB4CE2EA3B982ABD6A9D2B9ECE1A02&fileName=/typescript-6.0.0-insiders.20250926.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: es6-shim
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/es6-shim/index.d.ts
    1:11  error  TypeScript@local compile error: 
Duplicate identifier 'IteratorResult'                                                                                                                          @definitelytyped/expect
  240:5   error  TypeScript@local compile error: 
All declarations of 'EPSILON' must have identical modifiers                                                                                                    @definitelytyped/expect
  275:5   error  TypeScript@local compile error: 
All declarations of 'MAX_SAFE_INTEGER' must have identical modifiers                                                                                           @definitelytyped/expect
  282:5   error  TypeScript@local compile error: 
All declarations of 'MIN_SAFE_INTEGER' must have identical modifiers                                                                                           @definitelytyped/expect
  338:5   error  TypeScript@local compile error: 
All declarations of 'flags' must have identical modifiers                                                                                                      @definitelytyped/expect
  502:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  567:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  576:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  587:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  597:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  612:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  612:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>'  @definitelytyped/expect
  624:23  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  625:48  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  626:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  626:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>'            @definitelytyped/expect

✖ 16 problems (16 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: wicg-file-system-access
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/wicg-file-system-access/index.d.ts
  149:9  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property '[Symbol.asyncIterator]' must be of type '() => FileSystemDirectoryHandleAsyncIterator<[string, FileSystemHandle]>', but here has type '{ (): FileSystemDirectoryHandleAsyncIterator<[string, FileSystemHandle]>; (): AsyncIterableIterator<[string, FileSystemFileHandle | FileSystemDirectoryHandle]>; }'  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/wicg-file-system-access/wicg-file-system-access-tests.ts
  56:30  error  TypeScript@local compile error: 
Property 'getFile' does not exist on type 'FileSystemHandle'                                                                                                                                                                                                                      @definitelytyped/expect
  58:43  error  TypeScript@local compile error: 
Argument of type 'FileSystemHandle' is not assignable to parameter of type 'FileSystemDirectoryHandle'.
  Type 'FileSystemHandle' is missing the following properties from type 'FileSystemDirectoryHandle': getDirectoryHandle, getFileHandle, removeEntry, resolve, and 7 more  @definitelytyped/expect

✖ 3 problems (3 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: es6-collections
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/es6-collections/index.d.ts
  16:11  error  TypeScript@local compile error: 
Duplicate identifier 'IteratorResult'                                                                                                                          @definitelytyped/expect
  41:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  47:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  61:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  67:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  83:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  83:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>'  @definitelytyped/expect
  96:23  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  97:47  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  98:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  98:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>'            @definitelytyped/expect

✖ 11 problems (11 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62111/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Git clone failed"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,370 62,370 ~ ~ ~ p=1.000 n=6
Types 50,386 50,386 ~ ~ ~ p=1.000 n=6
Memory used 195,188k (± 1.04%) 195,785k (± 0.72%) ~ 192,897k 196,455k p=0.810 n=6
Parse Time 1.57s (± 1.48%) 1.61s (± 1.14%) +0.04s (+ 2.22%) 1.58s 1.63s p=0.028 n=6
Bind Time 0.88s (± 1.18%) 0.87s (± 0.93%) ~ 0.86s 0.88s p=0.546 n=6
Check Time 11.72s (± 0.45%) 11.72s (± 0.52%) ~ 11.67s 11.81s p=1.000 n=6
Emit Time 3.43s (± 4.38%) 3.39s (± 4.74%) ~ 3.27s 3.61s p=0.936 n=6
Total Time 17.60s (± 1.00%) 17.59s (± 0.77%) ~ 17.46s 17.78s p=0.688 n=6
angular-1 - node (v18.15.0, x64)
Errors 1 1 ~ ~ ~ p=1.000 n=6
Symbols 948,914 948,766 -148 (- 0.02%) ~ ~ p=0.001 n=6
Types 410,884 410,928 +44 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 1,245,615k (± 0.00%) 1,245,563k (± 0.01%) ~ 1,245,440k 1,245,681k p=0.128 n=6
Parse Time 6.54s (± 0.62%) 6.53s (± 0.83%) ~ 6.46s 6.59s p=1.000 n=6
Bind Time 1.87s (± 0.28%) 1.87s (± 0.52%) ~ 1.86s 1.89s p=0.504 n=6
Check Time 32.21s (± 0.35%) 32.16s (± 0.25%) ~ 32.06s 32.27s p=0.422 n=6
Emit Time 14.80s (± 0.35%) 14.78s (± 0.43%) ~ 14.67s 14.84s p=0.748 n=6
Total Time 55.42s (± 0.17%) 55.34s (± 0.23%) ~ 55.15s 55.48s p=0.378 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,544,618 2,544,351 -267 (- 0.01%) ~ ~ p=0.001 n=6
Types 903,213 903,216 +3 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 2,830,018k (± 0.00%) 2,829,930k (± 0.01%) ~ 2,829,635k 2,830,063k p=0.471 n=6
Parse Time 8.72s (± 0.37%) 8.71s (± 0.34%) ~ 8.68s 8.75s p=0.462 n=6
Bind Time 2.21s (± 0.67%) 2.19s (± 0.24%) -0.02s (- 0.98%) 2.18s 2.19s p=0.010 n=6
Check Time 86.51s (± 0.98%) 86.52s (± 0.95%) ~ 85.73s 88.05s p=1.000 n=6
Emit Time 0.62s (±124.58%) 0.31s (± 1.68%) ~ 0.30s 0.31s p=0.784 n=6
Total Time 98.06s (± 1.20%) 97.73s (± 0.84%) ~ 96.95s 99.23s p=0.810 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,064 1,237,064 ~ ~ ~ p=1.000 n=6
Types 259,743 259,743 ~ ~ ~ p=1.000 n=6
Memory used 2,364,171k (± 0.01%) 2,485,784k (±11.94%) ~ 2,364,361k 3,092,216k p=0.066 n=6
Parse Time 5.12s (± 1.05%) 5.14s (± 1.32%) ~ 5.03s 5.24s p=0.687 n=6
Bind Time 1.77s (± 0.62%) 1.78s (± 0.77%) ~ 1.76s 1.80s p=0.357 n=6
Check Time 35.14s (± 0.29%) 35.28s (± 0.46%) ~ 35.07s 35.57s p=0.054 n=6
Emit Time 3.01s (± 1.31%) 3.00s (± 1.00%) ~ 2.96s 3.04s p=0.747 n=6
Total Time 45.05s (± 0.29%) 45.20s (± 0.51%) ~ 44.98s 45.64s p=0.298 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,064 1,237,064 ~ ~ ~ p=1.000 n=6
Types 259,743 259,743 ~ ~ ~ p=1.000 n=6
Memory used 3,158,255k (± 0.01%) 3,157,422k (± 0.02%) -833k (- 0.03%) 3,156,561k 3,158,576k p=0.045 n=6
Parse Time 6.87s (± 1.05%) 6.79s (± 0.66%) -0.08s (- 1.12%) 6.73s 6.85s p=0.045 n=6
Bind Time 2.14s (± 0.87%) 2.15s (± 0.90%) ~ 2.12s 2.17s p=0.373 n=6
Check Time 42.57s (± 0.24%) 42.54s (± 0.44%) ~ 42.34s 42.83s p=0.936 n=6
Emit Time 3.53s (± 1.85%) 3.54s (± 1.31%) ~ 3.49s 3.61s p=1.000 n=6
Total Time 55.10s (± 0.25%) 55.03s (± 0.28%) ~ 54.88s 55.28s p=0.336 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,412 262,412 ~ ~ ~ p=1.000 n=6
Types 103,924 103,924 ~ ~ ~ p=1.000 n=6
Memory used 440,564k (± 0.04%) 440,471k (± 0.02%) ~ 440,349k 440,545k p=0.689 n=6
Parse Time 2.87s (± 0.65%) 2.88s (± 0.36%) ~ 2.86s 2.89s p=0.684 n=6
Bind Time 1.11s (± 0.73%) 1.11s (± 0.46%) ~ 1.11s 1.12s p=0.929 n=6
Check Time 15.85s (± 0.27%) 15.87s (± 0.17%) ~ 15.84s 15.90s p=0.685 n=6
Emit Time 1.32s (± 0.78%) 1.31s (± 0.92%) ~ 1.30s 1.33s p=0.675 n=6
Total Time 21.16s (± 0.13%) 21.17s (± 0.10%) ~ 21.14s 21.20s p=0.293 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 72 72 ~ ~ ~ p=1.000 n=6
Symbols 225,367 225,367 ~ ~ ~ p=1.000 n=6
Types 94,290 94,290 ~ ~ ~ p=1.000 n=6
Memory used 370,072k (± 0.05%) 370,013k (± 0.05%) ~ 369,881k 370,342k p=0.575 n=6
Parse Time 2.85s (± 0.54%) 2.84s (± 0.73%) ~ 2.81s 2.86s p=0.250 n=6
Bind Time 1.61s (± 1.09%) 1.59s (± 1.41%) ~ 1.56s 1.63s p=0.255 n=6
Check Time 16.47s (± 0.18%) 16.44s (± 0.42%) ~ 16.36s 16.54s p=0.335 n=6
Emit Time 0.00s (±244.70%) 0.00s (±244.70%) ~ 0.00s 0.01s p=1.000 n=6
Total Time 20.93s (± 0.18%) 20.88s (± 0.41%) ~ 20.79s 21.01s p=0.229 n=6
vscode - node (v18.15.0, x64)
Errors 3 4 🔻+1 (+33.33%) ~ ~ p=0.001 n=6
Symbols 3,884,524 3,884,386 -138 (- 0.00%) ~ ~ p=0.001 n=6
Types 1,222,624 1,222,727 +103 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 3,700,830k (± 0.01%) 3,700,824k (± 0.01%) ~ 3,700,446k 3,701,079k p=0.873 n=6
Parse Time 15.11s (± 0.68%) 15.27s (± 0.49%) +0.16s (+ 1.06%) 15.15s 15.35s p=0.031 n=6
Bind Time 4.94s (± 0.59%) 4.91s (± 0.54%) ~ 4.87s 4.94s p=0.076 n=6
Check Time 102.40s (± 3.21%) 102.29s (± 3.66%) ~ 98.86s 108.10s p=0.810 n=6
Emit Time 35.58s (±17.79%) 33.23s (±12.25%) ~ 30.45s 39.60s p=0.689 n=6
Total Time 158.03s (± 3.37%) 155.70s (± 4.55%) ~ 149.97s 167.93s p=0.378 n=6
webpack - node (v18.15.0, x64)
Errors 38 38 ~ ~ ~ p=1.000 n=6
Symbols 361,753 362,835 +1,082 (+ 0.30%) ~ ~ p=0.001 n=6
Types 158,862 159,472 +610 (+ 0.38%) ~ ~ p=0.001 n=6
Memory used 516,461k (± 0.01%) 519,853k (± 0.02%) +3,392k (+ 0.66%) 519,784k 519,971k p=0.005 n=6
Parse Time 4.43s (± 0.48%) 4.45s (± 1.02%) ~ 4.40s 4.52s p=0.517 n=6
Bind Time 1.92s (± 1.89%) 1.94s (± 1.75%) ~ 1.90s 1.98s p=0.517 n=6
Check Time 21.80s (± 0.35%) 21.97s (± 0.42%) +0.17s (+ 0.76%) 21.83s 22.09s p=0.020 n=6
Emit Time 0.00s (±244.70%) 0.00s (±244.70%) ~ 0.00s 0.01s p=1.000 n=6
Total Time 28.16s (± 0.39%) 28.36s (± 0.40%) +0.21s (+ 0.73%) 28.21s 28.48s p=0.020 n=6
xstate-main - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 672,791 673,174 +383 (+ 0.06%) ~ ~ p=0.001 n=6
Types 201,962 201,964 +2 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 574,873k (± 0.02%) 575,586k (± 0.03%) +713k (+ 0.12%) 575,336k 575,773k p=0.005 n=6
Parse Time 4.17s (± 0.61%) 4.20s (± 0.70%) +0.03s (+ 0.72%) 4.15s 4.24s p=0.043 n=6
Bind Time 1.35s (± 1.21%) 1.34s (± 0.99%) ~ 1.32s 1.36s p=0.553 n=6
Check Time 20.62s (± 2.10%) 20.48s (± 1.46%) ~ 20.20s 20.88s p=0.520 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 26.13s (± 1.72%) 26.03s (± 1.13%) ~ 25.78s 26.41s p=0.689 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@jakebailey
Copy link
Member Author

@saschanaz Just as an FYI, this is something we're planning on taking for 6.0, to settle this all once and for all. So, DOM will once again be evergreen.

@saschanaz
Copy link
Contributor

@saschanaz Just as an FYI, this is something we're planning on taking for 6.0, to settle this all once and for all. So, DOM will once again be evergreen.

Cool. While we are at it, can we please stop calling it DOM (or at least add an alias)? That's very very small portion of what we have in the lib...

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62111/merge:

Something interesting changed - please have a look.

Details

omnivore-app/omnivore

11 of 25 projects failed to build with the old tsc and were ignored

packages/api/tsconfig.json

react-bootstrap/react-bootstrap

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

test/tsconfig.json

@saschanaz
Copy link
Contributor

Update DOM-lib-generator to do this

Do you have a plan how to do this? Add another subdirectory in baselines?

@jakebailey
Copy link
Member Author

Yes, same diff as we did for the 5.8/5.6 dirs; I will send a patch soon.

@jakebailey
Copy link
Member Author

Cool. While we are at it, can we please stop calling it DOM (or at least add an alias)? That's very very small portion of what we have in the lib...

I don't see this happening, really ☹️

What would you suggest, if you had to choose? web?

@jakebailey jakebailey mentioned this pull request Sep 26, 2025
Merged
@saschanaz
Copy link
Contributor

saschanaz commented Sep 26, 2025 •
edited
Loading

What would you suggest, if you had to choose? web?

either web or webapi. I'd be fine having dom as a legacy alias of a new name, but it should really not be the only name 🥺

@jakebailey jakebailey mentioned this pull request Sep 26, 2025
Merged
@jakebailey
Copy link
Member Author

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 2, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started ✅ Results
run dt ✅ Started 👀 Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: es6-shim
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/es6-shim/index.d.ts
    1:11  error  TypeScript@local compile error: 
Duplicate identifier 'IteratorResult'                                                                                                                          @definitelytyped/expect
  240:5   error  TypeScript@local compile error: 
All declarations of 'EPSILON' must have identical modifiers                                                                                                    @definitelytyped/expect
  275:5   error  TypeScript@local compile error: 
All declarations of 'MAX_SAFE_INTEGER' must have identical modifiers                                                                                           @definitelytyped/expect
  282:5   error  TypeScript@local compile error: 
All declarations of 'MIN_SAFE_INTEGER' must have identical modifiers                                                                                           @definitelytyped/expect
  338:5   error  TypeScript@local compile error: 
All declarations of 'flags' must have identical modifiers                                                                                                      @definitelytyped/expect
  502:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  567:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  576:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  587:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  597:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  612:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  612:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>'  @definitelytyped/expect
  624:23  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  625:48  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  626:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  626:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>'            @definitelytyped/expect

✖ 16 problems (16 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: wicg-file-system-access
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/wicg-file-system-access/index.d.ts
  149:9  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property '[Symbol.asyncIterator]' must be of type '() => FileSystemDirectoryHandleAsyncIterator<[string, FileSystemHandle]>', but here has type '{ (): FileSystemDirectoryHandleAsyncIterator<[string, FileSystemHandle]>; (): AsyncIterableIterator<[string, FileSystemFileHandle | FileSystemDirectoryHandle]>; }'  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/wicg-file-system-access/wicg-file-system-access-tests.ts
  56:30  error  TypeScript@local compile error: 
Property 'getFile' does not exist on type 'FileSystemHandle'                                                                                                                                                                                                                      @definitelytyped/expect
  58:43  error  TypeScript@local compile error: 
Argument of type 'FileSystemHandle' is not assignable to parameter of type 'FileSystemDirectoryHandle'.
  Type 'FileSystemHandle' is missing the following properties from type 'FileSystemDirectoryHandle': getDirectoryHandle, getFileHandle, removeEntry, resolve, and 7 more  @definitelytyped/expect

✖ 3 problems (3 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: es6-collections
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/es6-collections/index.d.ts
  16:11  error  TypeScript@local compile error: 
Duplicate identifier 'IteratorResult'                                                                                                                          @definitelytyped/expect
  41:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  47:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  61:5   error  TypeScript@local compile error: 
All declarations of 'size' must have identical modifiers                                                                                                       @definitelytyped/expect
  67:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  83:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  83:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakMap<object, any>', but here has type 'WeakMap<any, any>'  @definitelytyped/expect
  96:23  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  97:47  error  TypeScript@local compile error: 
Type 'T' does not satisfy the constraint 'object'                                                                                                              @definitelytyped/expect
  98:5   error  TypeScript@local compile error: 
All declarations of 'prototype' must have identical modifiers                                                                                                  @definitelytyped/expect
  98:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'prototype' must be of type 'WeakSet<object>', but here has type 'WeakSet<any>'            @definitelytyped/expect

✖ 11 problems (11 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62111/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Git clone failed"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,370 62,370 ~ ~ ~ p=1.000 n=6
Types 50,386 50,386 ~ ~ ~ p=1.000 n=6
Memory used 194,530k (± 1.09%) 196,380k (± 0.07%) ~ 196,168k 196,554k p=0.471 n=6
Parse Time 1.59s (± 1.22%) 1.58s (± 1.16%) ~ 1.55s 1.60s p=0.607 n=6
Bind Time 0.88s (± 0.59%) 0.89s (± 1.56%) ~ 0.87s 0.91s p=0.242 n=6
Check Time 11.73s (± 0.32%) 11.71s (± 0.50%) ~ 11.63s 11.78s p=0.377 n=6
Emit Time 3.41s (± 4.23%) 3.32s (± 3.04%) ~ 3.26s 3.53s p=0.416 n=6
Total Time 17.61s (± 0.66%) 17.50s (± 0.78%) ~ 17.40s 17.77s p=0.093 n=6
angular-1 - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 954,914 955,117 +203 (+ 0.02%) ~ ~ p=0.001 n=6
Types 415,571 415,619 +48 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 1,254,044k (± 0.00%) 1,254,601k (± 0.00%) +557k (+ 0.04%) 1,254,542k 1,254,668k p=0.005 n=6
Parse Time 6.53s (± 0.64%) 6.51s (± 1.29%) ~ 6.45s 6.66s p=0.374 n=6
Bind Time 1.88s (± 0.48%) 1.88s (± 0.29%) ~ 1.88s 1.89s p=0.341 n=6
Check Time 32.20s (± 0.38%) 32.20s (± 0.26%) ~ 32.11s 32.35s p=1.000 n=6
Emit Time 14.84s (± 0.33%) 14.88s (± 0.50%) ~ 14.79s 14.97s p=0.336 n=6
Total Time 55.46s (± 0.23%) 55.47s (± 0.32%) ~ 55.25s 55.68s p=0.872 n=6
mui-docs - node (v18.15.0, x64)
Errors 1 1 ~ ~ ~ p=1.000 n=6
Symbols 557,130 556,863 -267 (- 0.05%) ~ ~ p=0.001 n=6
Types 89 89 ~ ~ ~ p=1.000 n=6
Memory used 836,650k (± 0.01%) 836,510k (± 0.01%) -139k (- 0.02%) 836,464k 836,678k p=0.030 n=6
Parse Time 10.57s (± 0.35%) 10.58s (± 0.30%) ~ 10.52s 10.62s p=0.683 n=6
Bind Time 2.71s (± 0.75%) 2.70s (± 0.56%) ~ 2.68s 2.72s p=0.330 n=6
Check Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Emit Time 0.34s (± 2.63%) 0.34s (± 2.22%) ~ 0.33s 0.35s p=0.798 n=6
Total Time 13.62s (± 0.24%) 13.61s (± 0.24%) ~ 13.56s 13.64s p=0.936 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,220 1,237,220 ~ ~ ~ p=1.000 n=6
Types 259,836 259,836 ~ ~ ~ p=1.000 n=6
Memory used 2,852,829k (±13.15%) 3,095,493k (± 0.03%) ~ 3,093,975k 3,096,126k p=0.173 n=6
Parse Time 6.60s (± 1.76%) 6.62s (± 0.67%) ~ 6.54s 6.66s p=0.689 n=6
Bind Time 2.15s (± 1.60%) 2.14s (± 1.40%) ~ 2.10s 2.18s p=0.687 n=6
Check Time 42.40s (± 0.42%) 42.56s (± 0.37%) ~ 42.32s 42.80s p=0.128 n=6
Emit Time 3.48s (± 2.36%) 3.49s (± 2.43%) ~ 3.40s 3.61s p=0.810 n=6
Total Time 54.62s (± 0.53%) 54.80s (± 0.44%) ~ 54.44s 55.16s p=0.471 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,220 1,237,220 ~ ~ ~ p=1.000 n=6
Types 259,836 259,836 ~ ~ ~ p=1.000 n=6
Memory used 3,159,315k (± 0.02%) 3,037,652k (± 9.73%) ~ 2,433,785k 3,159,291k p=0.093 n=6
Parse Time 6.85s (± 0.53%) 6.79s (± 1.48%) ~ 6.60s 6.89s p=0.261 n=6
Bind Time 2.16s (± 0.81%) 2.17s (± 0.86%) ~ 2.15s 2.19s p=0.676 n=6
Check Time 42.55s (± 0.26%) 42.48s (± 0.76%) ~ 42.03s 42.96s p=0.575 n=6
Emit Time 3.53s (± 2.57%) 3.54s (± 4.41%) ~ 3.36s 3.82s p=0.810 n=6
Total Time 55.11s (± 0.30%) 54.97s (± 0.83%) ~ 54.35s 55.41s p=0.936 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,524 262,524 ~ ~ ~ p=1.000 n=6
Types 104,015 104,015 ~ ~ ~ p=1.000 n=6
Memory used 440,594k (± 0.02%) 440,633k (± 0.01%) ~ 440,596k 440,696k p=0.336 n=6
Parse Time 3.52s (± 1.03%) 3.51s (± 1.23%) ~ 3.45s 3.57s p=0.686 n=6
Bind Time 1.32s (± 0.62%) 1.32s (± 1.12%) ~ 1.30s 1.34s p=0.508 n=6
Check Time 18.99s (± 0.39%) 19.02s (± 0.60%) ~ 18.90s 19.17s p=0.748 n=6
Emit Time 1.52s (± 1.58%) 1.53s (± 0.89%) ~ 1.50s 1.54s p=0.188 n=6
Total Time 25.35s (± 0.21%) 25.37s (± 0.58%) ~ 25.20s 25.58s p=0.810 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 72 72 ~ ~ ~ p=1.000 n=6
Symbols 225,367 225,367 ~ ~ ~ p=1.000 n=6
Types 94,290 94,290 ~ ~ ~ p=1.000 n=6
Memory used 370,144k (± 0.06%) 370,131k (± 0.03%) ~ 370,020k 370,265k p=0.936 n=6
Parse Time 2.85s (± 1.83%) 2.85s (± 0.91%) ~ 2.81s 2.87s p=1.000 n=6
Bind Time 1.61s (± 1.08%) 1.60s (± 0.75%) ~ 1.59s 1.62s p=0.188 n=6
Check Time 16.45s (± 0.28%) 16.45s (± 0.33%) ~ 16.38s 16.50s p=1.000 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 20.91s (± 0.31%) 20.90s (± 0.31%) ~ 20.79s 20.97s p=0.747 n=6
vscode - node (v18.15.0, x64)
Errors 5 6 🔻+1 (+20.00%) ~ ~ p=0.001 n=6
Symbols 3,903,045 3,902,896 -149 (- 0.00%) ~ ~ p=0.001 n=6
Types 1,228,305 1,228,385 +80 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 3,715,736k (± 0.01%) 3,715,631k (± 0.01%) ~ 3,715,351k 3,715,922k p=0.378 n=6
Parse Time 15.35s (± 0.21%) 15.30s (± 0.51%) ~ 15.21s 15.41s p=0.258 n=6
Bind Time 4.93s (± 0.70%) 4.92s (± 0.33%) ~ 4.91s 4.95s p=0.871 n=6
Check Time 102.44s (± 3.06%) 102.09s (± 2.56%) ~ 99.41s 106.35s p=0.810 n=6
Emit Time 33.80s (±19.73%) 35.77s (± 7.87%) ~ 30.64s 37.79s p=0.173 n=6
Total Time 156.52s (± 3.58%) 158.10s (± 2.46%) ~ 154.08s 164.28s p=0.471 n=6
webpack - node (v18.15.0, x64)
Errors 39 39 ~ ~ ~ p=1.000 n=6
Symbols 370,006 371,088 +1,082 (+ 0.29%) ~ ~ p=0.001 n=6
Types 161,904 162,501 +597 (+ 0.37%) ~ ~ p=0.001 n=6
Memory used 524,648k (± 0.02%) 526,177k (± 0.01%) +1,528k (+ 0.29%) 526,097k 526,248k p=0.005 n=6
Parse Time 4.46s (± 0.59%) 4.47s (± 1.06%) ~ 4.39s 4.52s p=0.805 n=6
Bind Time 1.91s (± 0.96%) 1.92s (± 1.49%) ~ 1.89s 1.97s p=0.418 n=6
Check Time 21.90s (± 0.48%) 22.00s (± 0.19%) ~ 21.95s 22.06s p=0.053 n=6
Emit Time 0.00s (±244.70%) 0.00s ~ ~ ~ p=0.405 n=6
Total Time 28.27s (± 0.35%) 28.39s (± 0.21%) ~ 28.27s 28.43s p=0.077 n=6
xstate-main - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 673,247 673,630 +383 (+ 0.06%) ~ ~ p=0.001 n=6
Types 202,036 202,036 ~ ~ ~ p=1.000 n=6
Memory used 575,503k (± 0.02%) 576,150k (± 0.03%) +648k (+ 0.11%) 576,025k 576,370k p=0.005 n=6
Parse Time 4.19s (± 0.85%) 4.18s (± 0.65%) ~ 4.16s 4.23s p=1.000 n=6
Bind Time 1.34s (± 1.19%) 1.35s (± 1.58%) ~ 1.33s 1.38s p=0.462 n=6
Check Time 20.61s (± 1.80%) 20.75s (± 1.76%) ~ 20.24s 21.03s p=0.470 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 26.14s (± 1.40%) 26.29s (± 1.49%) ~ 25.75s 26.60s p=0.575 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62111/merge:

Something interesting changed - please have a look.

Details

omnivore-app/omnivore

12 of 25 projects failed to build with the old tsc and were ignored

packages/api/tsconfig.json

react-bootstrap/react-bootstrap

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

test/tsconfig.json

@jakebailey jakebailey changed the title Move DOM.Iterable/AsyncIterable into DOM Move Iterable/AsyncIterable into main DOM/WebWorker libs Oct 2, 2025
@jakebailey
Copy link
Member Author

jakebailey commented Oct 2, 2025 •
edited
Loading

DT errors are:

  • shim packages (es6-shim, es6-collections) that try to define old environments. But now DOM loads es6 so they break. Fix is probably to not include dom types in those packages, or just drop them.
  • wicg-file-system-access not matching DOM. Common problem, solvable with fixes or typesVersions.

Perf benchmark shows VS Code regressing. This is also due to wicg-file-system-access.

Top tests:

  • omnivore: not sure what's going on here. Seems unrelated but clearly it's regressing somehow. It's some langchain code so not where where DOM comes into play.
  • react-bootstrap: They are assuming they can index all CSS declaration types into HTMLElement, which doesn't work now that CSSStyleDeclaration has async members.

Neither affect a public API.

But, in general, it's just the addition of *.{,Async}Iterable that are causing this. All of these problems can happen today. So there's nothing super scary here at all.

@jakebailey jakebailey marked this pull request as ready for review October 2, 2025 20:33
Copilot
Copilot AI reviewed Oct 2, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jakebailey jakebailey merged commit ced90d9 into microsoft:main Oct 2, 2025
33 checks passed
@jakebailey jakebailey deleted the jabaile/dom-es6 branch October 2, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@andrewbranch andrewbranch andrewbranch approved these changes

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tsconfig.json "lib": "dom" should include "dom.iterable"(?)
5 participants
@jakebailey @typescript-bot @saschanaz @andrewbranch @RyanCavanaugh