Allow unknown type annotation on catch clause variable #36776
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
reviewed
Feb 13, 2020
| === tests/cases/compiler/catchClauseWithUnknownTypeAnnotation.ts === | ||
| try { | ||
| } catch (e: unknown) { | ||
| >e : any |
There was a problem hiding this comment.
Seems like the type annotation is not working as expected.
|
also added a commit to address type alias case. |
sandersn
added
For Backlog Bug
ExE-Boss
reviewed
May 31, 2020
| // Grammar checking | ||
| if (catchClause.variableDeclaration) { | ||
| if (catchClause.variableDeclaration.type) { | ||
| if (catchClause.variableDeclaration.type && tryGetTypeFromEffectiveTypeNode(catchClause.variableDeclaration) !== unknownType) { |
There was a problem hiding this comment.
See #36775 (comment)
Suggested change
| if (catchClause.variableDeclaration.type && tryGetTypeFromEffectiveTypeNode(catchClause.variableDeclaration) !== unknownType) { | |
| if (catchClause.variableDeclaration.type && tryGetTypeFromEffectiveTypeNode(catchClause.variableDeclaration) !== anyType && tryGetTypeFromEffectiveTypeNode(catchClause.variableDeclaration) !== unknownType) { |
|
Closing in favor of #39015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36775