implementations: Use declaration name for the span #24537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
May 31, 2018
src/services/findAllReferences.ts
Outdated
| // need to "Find all References" | ||
| const symbol = checker.getSymbolAtLocation(node)!; | ||
| return symbol.valueDeclaration && [nodeEntry(symbol.valueDeclaration)]; | ||
| return symbol.valueDeclaration && [nodeEntry((symbol.valueDeclaration as NamedDeclaration).name || symbol.valueDeclaration)]; |
There was a problem hiding this comment.
why not instead make nodeEntry do node.name || node as the span?
sheetalkamat
approved these changes
May 31, 2018
ghost
merged commit 
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the implementations part of #15109
Instead of adding a second span, I don't think there's a particular reason we used the full declaration span in the first place -- the rest of find-all-references uses the name span.