Restore implicitly converting cases in the test for P0466R5 #5737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of removing the problematic test cases, this PR reintroduces and fixes them by fully specifying template arguments to enable intentional implicit conversions.
StephanTLavavej
approved these changes
Sep 23, 2025
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for preserving this test coverage and getting the Standard fixed up! 😻 🛠️ 📜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of removing the problematic test cases (#5730), this PR reintroduces and fixes them by fully specifying template arguments to enable intentional implicit conversions.
Corresponding fix for the example in the standard is submitted in cplusplus/draft#8245.