Skip to content

Improve existing vector<bool> benchmarks #5732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

Improve existing vector<bool> benchmarks #5732

merged 1 commit into from
Sep 25, 2025

Conversation

AlexGuteniev
Copy link
Contributor

The following minor changes:

  • Extract createRandomVector, use the version that doesn't use static, and rename it to random_bool_vector for consitency.
  • Use optimization barriers, and avoid const on source to make them effective.
  • Remove one stray newline.

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner September 19, 2025 19:24
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Sep 19, 2025
@StephanTLavavej StephanTLavavej added the test Related to test code label Sep 19, 2025
@StephanTLavavej StephanTLavavej self-assigned this Sep 19, 2025
@StephanTLavavej StephanTLavavej added the performance Must go faster label Sep 19, 2025
@StephanTLavavej StephanTLavavej removed their assignment Sep 25, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Sep 25, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Sep 25, 2025
@StephanTLavavej StephanTLavavej merged commit af895f2 into microsoft:main Sep 25, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Sep 25, 2025
@StephanTLavavej
Copy link
Member

🧹 ⏱️ 😸

@AlexGuteniev AlexGuteniev deleted the before-dinosaurs branch September 26, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees
No one assigned
Labels
performance Must go faster test Related to test code
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexGuteniev @StephanTLavavej