<regex>
: Speed up skip optimization for default regex_traits
in collate
mode
#5672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the default
std::regex_traits<char>
andstd::regex_traits<wchar_t>
implementation, thetranslate()
function just returns its argument unchanged (see [re.traits]/4). This means that the call to this function can be skipped for these traits classes.This PR implements this change, and as a consequence, the skip optimization now engages the vectorized
std::search
implementation incollate
mode as well.The tests added by #5553 already check correct handling of
translate()
in the skip optimization for user-provided regex traits, so this PR just adds a short variant of this test for defaultstd::regex
andstd::wregex
.Benchmark (only relevant lines):