Skip to content

<chrono>: qualify _Ugly function calls to avoid ADL #5629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2025
Merged

<chrono>: qualify _Ugly function calls to avoid ADL #5629

merged 2 commits into from
Aug 8, 2025

Conversation

localspook
Copy link
Contributor

@localspook localspook commented Jun 30, 2025 •
edited
Loading

Towards #140. These changes were generated automatically with a script.

@localspook localspook requested a review from a team as a code owner June 30, 2025 17:30
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Jun 30, 2025
@localspook localspook mentioned this pull request Jun 30, 2025
Open
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Jul 2, 2025
@StephanTLavavej StephanTLavavej self-assigned this Jul 2, 2025
@StephanTLavavej
Copy link
Member

Thanks! 😸 I pushed a merge with main to resolve fairly simple merge conflicts, and double-checked that _Fill_tm and _Throw_format_error are always qualified here.

@StephanTLavavej StephanTLavavej removed their assignment Jul 23, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Jul 23, 2025
@StephanTLavavej StephanTLavavej added the chrono C++20 chrono label Jul 23, 2025
@StephanTLavavej StephanTLavavej mentioned this pull request Jul 23, 2025
Open
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Aug 7, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit c2097a1 into microsoft:main Aug 8, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Aug 8, 2025
@StephanTLavavej
Copy link
Member

Thanks for improving the STL's resistance to our least favorite lookup, and congratulations on your first microsoft/STL commit! 🎉 😸 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees
No one assigned
Labels
bug Something isn't working chrono C++20 chrono
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localspook @StephanTLavavej