Skip to content

<regex>: Limit recursion in the parser #5588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

<regex>: Limit recursion in the parser #5588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion stl/inc/regex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4236,7 +4236,7 @@ _BidIt _Matcher2<_BidIt, _Elem, _RxTraits, _It, _Alloc>::_Skip(
}

_Node_assert* _Node = static_cast<_Node_assert*>(_Nx);
_First_arg = _Skip(_First_arg, _Last, _Node->_Child);
_First_arg = _Skip(_First_arg, _Last, _Node->_Child, _Recursion_depth + 1U);
_BidIt _Next;
for (;;) {
_Next = _Skip(_First_arg, _Last, _Node->_Next, _Recursion_depth + 1U);
Expand Down Expand Up @@ -4703,6 +4703,10 @@ void _Parser2<_FwdIt, _Elem, _RxTraits>::_Do_assert_group(bool _Neg) { // add as
template <class _FwdIt, class _Elem, class _RxTraits>
bool _Parser2<_FwdIt, _Elem, _RxTraits>::_Wrapped_disjunction() { // add disjunction inside group
++_Disj_count;
if (_Disj_count >= 1000) { // hardcoded limit
_Error(regex_constants::error_stack);
}

if (!(_L_flags & _L_empty_grp) && _Mchar == _Meta_rpar) {
_Error(regex_constants::error_paren);
} else if ((_L_flags & _L_nc_asrt) && _Mchar == _Meta_query) { // check for valid ECMAScript (?x ... ) group
Expand Down