<regex>: Fix quadratic complexity in regex_search when regex starts with ? quantifier or several alternatives
#5457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts with `?` quantifier or several alternatives
AlexGuteniev
reviewed
May 1, 2025
StephanTLavavej
added
performance
StephanTLavavej
approved these changes
May 3, 2025
|
Locally verified too. Given the very clear comment, and the difficulty of verifying this in automated testing without burning a bunch of CPU time, I'm okay with not having test coverage for this. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
May 9, 2025
|
O(Thanks2) 😹 🚀 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5452. This is the minimal fix in
_Matcher::_Skipthat I mentioned in the issue: It avoids worst-case running time quadratic in the size of the searched string by giving up on_N_ifnodes with two or more branches.Unfortunately, we can't just give up whenever an
_N_ifis encountered because the parser currently likes to generate such nodes with a single branch. In particular, there is one such node at the beginning of each generated NFA. This means that giving up on such nodes would render_Skippointless for all regular expressions.I confirmed locally that this change is sufficient to fix the quadratic running time that #5452's test case exposes (though the quantifiers still almost double the running time.)