Add is_implicit_lifetime trait (for Clang)
#5445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TymianekPL <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: TymianekPL <[email protected]>
Signed-off-by: TymianekPL <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
|
@microsoft-github-policy-service agree |
This comment was marked as resolved.
This comment was marked as resolved.
frederick-vs-ja
suggested changes
Apr 28, 2025
tests/std/tests/P2674R1_is_implicit_lifetime/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2674R1_is_implicit_lifetime/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from Initial Review
to Work In Progress
in STL Code Reviews
StephanTLavavej
added
blocked
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
cpplearner
reviewed
Apr 29, 2025
Signed-off-by: TymianekPL <[email protected]>
Signed-off-by: TymianekPL <[email protected]>
Signed-off-by: TymianekPL <[email protected]>
Signed-off-by: TymianekPL <[email protected]>
Include `<cstddef>` for `nullptr_t`. Move up the using-directive. Use `enum class`. Rename scoped enumerator to `Enumerator2`. Drop unnecessary comment. Strictly verify both variable template and struct. Add preprocessor comment.
tests/std/tests/VSO_0157762_feature_test_macros/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2674R1_is_implicit_lifetime/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2674R1_is_implicit_lifetime/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2674R1_is_implicit_lifetime/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2674R1_is_implicit_lifetime/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2674R1_is_implicit_lifetime/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Sep 24, 2025
StephanTLavavej
approved these changes
Sep 24, 2025
|
Thanks! 😻 I pushed a bunch of changes and filed followup issues/bugs:
At the last minute, I remembered to check libcxx's tests, and updated the expected failures to mention a likely bogus test. |
StephanTLavavej
approved these changes
Sep 25, 2025
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for bringing us one step closer to C++23 conformance! 😻 🎉 🐈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang has added the
std::is_implicit_lifetimetrait in LLVM20, and this is an implementation for MSVC STL for Clang. Since MSVC core compiler does not support the builtin yet, I will not include the MSVC version in this PR (unless something changes throughout the lifetime of this PR).Changes:
std::is_implicit_lifetimetrait (andstd::is_implicit_lifetime_v).[Fixes #3445]