Test coverage for search_n with impossible value
#5440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this from Initial Review
to Done
in STL Code Reviews
github-project-automation
bot
moved this from Done
to Initial Review
in STL Code Reviews
StephanTLavavej
approved these changes
May 3, 2025
|
Thanks for correcting my oversight! 😻 |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
May 9, 2025
😻 🕵️ 🔎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for adding some impossible coverage to vector algorithms, @StephanTLavavej! (#5355)
But you seem to miss the one you've then-recently reviewed 😹 (#5352)
I had to damage the sequence in the test array a bit, because for
search_ncoverage to properly cover the right branch, we need to search for more than one consecutive element, otherwise we get special n=1 case.