Skip to content

Fix inconsistent use of normal_distribution in benchmarks and tests #5404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Fix inconsistent use of normal_distribution in benchmarks and tests #5404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1801f47
Fix inconsistent use of `normal_distribution` in benchmarks and tests
AlexGuteniev Apr 12, 2025
d4545d6
zero consistency
AlexGuteniev Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/src/adjacent_difference.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ void bm(benchmark::State& state) {
vector<T> output(size);

if constexpr (is_floating_point_v<T>) {
normal_distribution<T> dis(-100.0, 100.0);
normal_distribution<T> dis(0, 100000.0);
ranges::generate(input, [&] { return dis(gen); });
} else {
static_assert(is_unsigned_v<T>, "This avoids signed integers to avoid UB; they shouldn't perform differently");
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/src/minmax_element.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ void bm(benchmark::State& state) {
mt19937 gen(84710);

if constexpr (is_floating_point_v<T>) {
normal_distribution<T> dis(0, 10000.0);
normal_distribution<T> dis(0, 100000.0);
ranges::generate(a, [&] { return dis(gen); });
} else {
uniform_int_distribution<conditional_t<sizeof(T) != 1, T, int>> dis(1, 20);
Expand Down
2 changes: 1 addition & 1 deletion tests/std/tests/VSO_0000000_vector_algorithms_floats/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ void test_min_max_element_floating_with_values(mt19937_64& gen, const vector<T>&

template <class T>
void test_min_max_element_floating_any(mt19937_64& gen) {
normal_distribution<T> dis(-100000.0, 100000.0);
normal_distribution<T> dis(0, 100000.0);

constexpr auto input_of_input_size = dataCount / 2;
vector<T> input_of_input(input_of_input_size);
Expand Down