<regex>: Allow initial ] to start character ranges in POSIX regular expressions
#5364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
added
bug
StephanTLavavej
changed the title
<regex>: Allow initial ] to start character ranges in POSIX regular expressions<regex>: Allow initial ] to start character ranges in POSIX regular expressions
StephanTLavavej
approved these changes
Apr 2, 2025
|
Thanks! 😻 I pushed changes to significantly expand the test coverage. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Resolved adjacent-add conflict in |
StephanTLavavej
approved these changes
Apr 10, 2025
🥕 💵 ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regex miscompilation noticed in #5165.
The POSIX standard says that the right bracket ] is not special at the beginning of a bracketed character class (https://pubs.opengroup.org/onlinepubs/009696699/basedefs/xbd_chap09.html#tag_09_03_05). This means that an initial ] behaves like any other character, so it may also be the start of a character range.