Skip to content

Conversation

frederick-vs-ja
Copy link
Contributor

By befriending basic_const_iterator specializations. Fixes #5321.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner March 6, 2025 04:30
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Mar 6, 2025
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Mar 6, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Work In Progress in STL Code Reviews Mar 6, 2025
@StephanTLavavej StephanTLavavej moved this from Work In Progress to Ready To Merge in STL Code Reviews Mar 6, 2025
@StephanTLavavej StephanTLavavej self-assigned this Mar 12, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Mar 12, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 48db4fa into microsoft:main Mar 13, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Mar 13, 2025
@StephanTLavavej
Copy link
Member

Thanks for fixing this compiler error! 🐱 🐈 🐈‍⬛

@frederick-vs-ja frederick-vs-ja deleted the fix-basic_const_iterator-conv branch March 13, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

<xutility>: basic_const_iterator<int *> cannot convert to basic_const_iterator<const int *>
4 participants