Unblock RWC by extending the static call operator workaround #5312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Justo <[email protected]>
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal VSO-2397560 "[RWC][prod/fe][Regression] Taichi build failed with error G444FFF0D: overloaded 'operator()' cannot be a static member function".
We build https://github.com/taichi-dev/taichi in our Real World Code test suite. They're using an older version of Clang/LLVM than we require (I believe it's Clang 14 🙀, when we now require Clang 19), and they've been defining our escape hatch macro to get away with this, but #5284's change to use C++23 WG21-P1169R4
static operator()downlevel has broken them.We need to work around CUDA 12.4's lack of support for static call operators, so we may as well extend this to ancient versions of Clang, but we are not attempting to support paleolithic compilers in general. In the future, when we can upgrade our minimum supported CUDA version to something that understands static call operators, we should entirely remove this workaround - if Taichi hasn't upgraded their Clang dependency by then, we'll have to file an issue and temporarily skip it in RWC.