<regex>: Limit backreference parsing to single digit for basic regular expressions
#5167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
requested changes
Dec 9, 2024
|
Excellent, thank you! 💚 I pushed small stylistic nitpicks. |
StephanTLavavej
approved these changes
Jan 11, 2025
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for properly implementing this grammar! 1️⃣ 9️⃣ 🐱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Sections 9.3.6 and 9.5.1 of the POSIX standard, a backreference is a backslash followed by a single digit, so
\1to\9. Thus,\(a\)\10is a valid basic regular expression matching the stringaa0, because\10is a backreference to capture group 1 (\(a\)) plus the digit 0. However, the regex parser currently rejects this regular expression because it interprets\10as a backreference to capture group 10.After this PR, the parser only reads a single digit in basic regular expression (and grep) mode, so
\10is parsed correctly as a backreference to capture group 1 plus digit 0.