Workaround Clang 18 issues in our test suite #4932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loat` Clang 18 is emitting this warning for all `/fp:fast` configurations. Filed microsoft#4931 to investigate, let's suppress the warnings for now.
CaseyCarter
changed the title
-Wnan-infinity-disabled in VSO_0000000_vector_algorithms_float
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Sep 4, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for scouting out the impending Clang version! 🏞️ 🔭 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Wnan-infinity-disabledinVSO_0000000_vector_algorithms_float. Clang 18 emits this warning for all of our/fp:fastconfigurations. Filed Clang 18+/fp:fastemits-Wnan-infinity-disabledinVSO_0000000_vector_algorithms_floats#4931 to investigate, let's suppress the warnings for now. Since it's a new warning, we also need-Wno-unknown-warning-optionto allow Clang 17 to keep accepting the test.ADDITIONAL_COMPILE_FLAGSto pass with Clang 18.