Skip to content

Added parse+tests for audio, video, and source elements. #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2015
Merged

Added parse+tests for audio, video, and source elements. #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Mf2/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ public function parseP(\DOMElement $p) {
public function parseU(\DOMElement $u) {
if (($u->tagName == 'a' or $u->tagName == 'area') and $u->getAttribute('href') !== null) {
$uValue = $u->getAttribute('href');
} elseif ($u->tagName == 'img' and $u->getAttribute('src') !== null) {
} elseif (in_array($u->tagName, array('img', 'audio', 'video', 'source')) and $u->getAttribute('src') !== null) {
$uValue = $u->getAttribute('src');
} elseif ($u->tagName == 'object' and $u->getAttribute('data') !== null) {
$uValue = $u->getAttribute('data');
Expand Down
39 changes: 39 additions & 0 deletions tests/Mf2/ParseUTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,4 +136,43 @@ public function testParsesHrefBeforeValueClass() {
$result = Mf2\parse($input);
$this->assertEquals('http://example.com/right', $result['items'][0]['properties']['url'][0]);
}

/**
* @group parseU
*/
public function testParseUHandlesAudio() {
$input = '<div class="h-entry"><audio class="u-audio" src="http://example.com/audio.mp3"></div>';
$parser = new Parser($input);
$output = $parser->parse();

$this->assertArrayHasKey('audio', $output['items'][0]['properties']);
$this->assertEquals('http://example.com/audio.mp3', $output['items'][0]['properties']['audio'][0]);
}

/**
* @group parseU
*/
public function testParseUHandlesVideo() {
$input = '<div class="h-entry"><video class="u-video" src="http://example.com/video.mp4"></video></div>';
$parser = new Parser($input);
$output = $parser->parse();

$this->assertArrayHasKey('video', $output['items'][0]['properties']);
$this->assertEquals('http://example.com/video.mp4', $output['items'][0]['properties']['video'][0]);
}


/**
* @group parseU
*/
public function testParseUHandlesSource() {
$input = '<div class="h-entry"><video><source class="u-video" src="http://example.com/video.mp4" type="video/mp4"><source class="u-video" src="http://example.com/video.ogg" type="video/ogg"></video></div>';
$parser = new Parser($input);
$output = $parser->parse();

$this->assertArrayHasKey('video', $output['items'][0]['properties']);
$this->assertEquals('http://example.com/video.mp4', $output['items'][0]['properties']['video'][0]);
$this->assertEquals('http://example.com/video.ogg', $output['items'][0]['properties']['video'][1]);
}

}