Narrow return value of EntityInterface->id() by previous calls to isNew on an instance of EntityInterface
#900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isNew` on an instance of `EntityInterface`
|
I'd also like to do this for |
mglaman
approved these changes
Aug 4, 2025
|
I like it. Too bad we can't pull it off with just stubs |
dpi
added a commit
to dpi/phpstan-drupal
that referenced
this pull request
Aug 5, 2025
Fixes a bug with mglaman#900 reported in https://www.drupal.org/project/experience_builder/issues/3539676 by @larowlan
dpi
added a commit
to dpi/phpstan-drupal
that referenced
this pull request
Aug 5, 2025
Fixes a bug with mglaman#900 reported in https://www.drupal.org/project/experience_builder/issues/3539676 by @larowlan
mglaman
pushed a commit
that referenced
this pull request
Aug 5, 2025
* 🐛 Narrow only by existing return types Fixes a bug with #900 reported in https://www.drupal.org/project/experience_builder/issues/3539676 by @larowlan * also test int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.