Skip to content

Add RevisionableStorageInterface::createRevision generic for return type #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2025
Merged

Add RevisionableStorageInterface::createRevision generic for return type #894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a745d24
createRevision returns an object instance of the same type passed to …
dpi Jul 29, 2025
d63f178
`TranslatableRevisionableStorageInterface::createRevision` has a diff…
dpi Jul 29, 2025
be9e472
typing
dpi Jul 29, 2025
0ef671e
another type
dpi Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions stubs/Drupal/Core/Entity/RevisionableStorageInterface.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,12 @@ interface RevisionableStorageInterface extends EntityStorageInterface {
* @param int|numeric-string $revision_id
*/
public function deleteRevision($revision_id): void;

/**
* @param R $entity
* @return R
* @template R of \Drupal\Core\Entity\RevisionableInterface
*/
public function createRevision(RevisionableInterface $entity, bool $default = TRUE);

}
7 changes: 7 additions & 0 deletions stubs/Drupal/Core/Entity/TranslatableRevisionableStorageInterface.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,11 @@ namespace Drupal\Core\Entity;
// This is fragile and relies on `ContentEntityStorageInterface` only implementing this interface.
interface TranslatableRevisionableStorageInterface extends RevisionableStorageInterface, TranslatableStorageInterface {

/**
* @param R $entity
* @return R
* @template R of \Drupal\Core\Entity\RevisionableInterface
*/
public function createRevision(RevisionableInterface $entity, bool $default = TRUE, ?bool $keep_untranslatable_fields = NULL);

}
Loading