Drop d9 #807
Merged
Drop d9 #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…\Rules\Deprecations\AccessDeprecatedConstant
…anDrupal\Rules\Deprecations\AccessDeprecatedConstant" This reverts commit 46ad904.
…tanDrupal\Rules\Deprecations\AccessDeprecatedConstant" This reverts commit 181a5df.
…\Rules\Deprecations\AccessDeprecatedConstant
…lassRuleTest::testRule ContentEntityDeleteForm test case and dependencies
…es\Deprecations\AccessDeprecatedConstant and dependencies
…st and its rule and related stuff 'n things
…ntationTest::testRule test for deprecated_field_widget_hooks_field_widget_form_alter and related stuff 'n things
…uleTest::testRuleDrupal8 and \mglaman\PHPStanDrupal\Tests\Rules\GetDeprecatedServiceRuleTest::testRuleDrupal9 and related stuff 'n things
…RuleTest::testRule and the rule and related stuff 'n things
…RuleTest::testRule and the rule and related stuff 'n things
…ectInterfaceConstantsRuleTest::testRule and the rule, \mglaman\PHPStanDrupal\Tests\Rules\SymfonyCmfRoutingInClassMethodSignatureRuleTest::testRule and the rule, and related stuff 'n things
This reverts commit c3da108.
|
Do we wanna keep |
|
Also, does CircleCI work with anything else but D9? Looking at If that's indeed the case, should we drop it entirely? |
|
We can kill CircleCI, it's a left over |
|
mglaman
reviewed
Nov 19, 2024
| - mglaman\PHPStanDrupal\Rules\Drupal\Coder\DiscouragedFunctionsRule | ||
| - mglaman\PHPStanDrupal\Rules\Drupal\GlobalDrupalDependencyInjectionRule | ||
| - mglaman\PHPStanDrupal\Rules\Drupal\PluginManager\PluginManagerSetsCacheBackendRule | ||
| - mglaman\PHPStanDrupal\Rules\Deprecations\AccessDeprecatedConstant |
There was a problem hiding this comment.
Do we need this rule in case future constants are deprecated? Or does PHP now support reading comments from constants... I think it does, so this rule isn't needed. Worth double checking.
There was a problem hiding this comment.
Yeah it's been out for a while https://x.com/markusstaab/status/1765984217937154473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #760