(torchx/entrypoints) remove redundant skip_defaults flag from entrypoints.load() #1140
+9
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83991870. |
…ints.load() (#1140) Summary: Removes the redunant (and potentially confusing) `skip_defaults` flag from: ``` from torchx.utils.entrypoints import load_group load_group(group, default, skip_defaults) ``` This is because the same can be achieved at the call-site by passing `default=None`. That is: ``` load_group(group_name, defaults=None if skip_defaults else default_value) ``` Coincidentally also fixes an illegal type return in `torchx.schedulers.get_scheduler_factories` (should always return a `dict[str, SchedulerFactory]` (an empty dict if none found) where passing `get_scheduler_factories(..., skip_defaults=True)` currently returns `None` which violates the return type hint. Differential Revision: D83991870
facebook-github-bot
force-pushed
the
export-D83991870
branch
from
3df5879 to
834e55a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
+ Coverage 91.60% 91.63% +0.03%
==========================================
Files 83 83
Lines 6431 6431
==========================================
+ Hits 5891 5893 +2
+ Misses 540 538 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AbishekS
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Removes the redunant (and potentially confusing)
skip_defaultsflag from:This is because the same can be achieved at the call-site by passing
default=None. That is:Coincidentally also fixes an illegal type return in
torchx.schedulers.get_scheduler_factories(should always return adict[str, SchedulerFactory](an empty dict if none found) where passingget_scheduler_factories(..., skip_defaults=True)currently returnsNonewhich violates the return type hint.Differential Revision: D83991870