(torchx/specs) Remove deprecated base_image attribute from Role #1138
+0
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83780899. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 6, 2025
Summary: `role.base_image` has been marked for deprecation for a few years. Remove it. Reviewed By: richardwang-at-fb Differential Revision: D83780899
facebook-github-bot
force-pushed
the
export-D83780899
branch
from
06ad544 to
6a014de
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1138 +/- ##
==========================================
- Coverage 91.64% 91.64% -0.01%
==========================================
Files 83 83
Lines 6441 6440 -1
==========================================
- Hits 5903 5902 -1
Misses 538 538
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: `role.base_image` has been marked for deprecation for a few years. Remove it. Reviewed By: richardwang-at-fb Differential Revision: D83780899
facebook-github-bot
force-pushed
the
export-D83780899
branch
from
6a014de to
620134f
Compare
|
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83780899. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
role.base_imagehas been marked for deprecation for a few years. Remove it.Differential Revision: D83780899