-
Notifications
You must be signed in to change notification settings - Fork 146
feat: add config-based named_resources support (#1085) #1086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
For your consideration @kiukchung , @d4l3k , @tonykao8080 , @andywag |
Could you please have a look, @kiukchung? |
Could you please have a look, @kiukchung , @d4l3k , @tonykao8080 , @andywag? |
Sorry for bugging, but could you please let me know what you think about this proposal, @kiukchung , @d4l3k , @tonykao8080 , @andywag ? |
@clumsy are you on the PyTorch Slack? Better to ping there, we get a lot of GitHub notifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, looks like it needs to be rebased
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1086 +/- ##
==========================================
+ Coverage 91.60% 91.67% +0.07%
==========================================
Files 83 84 +1
Lines 6431 6466 +35
==========================================
+ Hits 5891 5928 +37
+ Misses 540 538 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Seem to be OK still, right @d4l3k ? |
9a04d96
to
60f2bc2
Compare
Please check the latest changes, @kiukchung |
Fixes #1085
Test plan:
[x] Unit tests added
[x] Tested locally, e.g.:
Running
torchx run -s local_cwd utils.sh cal
Gives: