feat: add metadata parameters to dist/spmd components (#1037) #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
clumsy
force-pushed
the
feat/dist_ddp_metadata
branch
from
597d743 to
24c2cc4
Compare
kiukchung
approved these changes
May 1, 2025
|
@kiukchung has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Is there anything else left to do for this PR to get merged, @kiukchung ? Thanks! |
|
Hi @kiukchung is there something I can do to help merge this one? Thanks! |
yep. Can you try rebasing? |
clumsy
force-pushed
the
feat/dist_ddp_metadata
branch
from
24c2cc4 to
1429367
Compare
|
Done, @kiukchung. I don't see any issues locally. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1038 +/- ##
==========================================
+ Coverage 91.60% 91.63% +0.03%
==========================================
Files 83 83
Lines 6431 6431
==========================================
+ Hits 5891 5893 +2
+ Misses 540 538 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1037 1037
Test plan:
[x] updated unit tests