Skip to content

Conversation

liangel-02
Copy link
Contributor

No description provided.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 26, 2025
@liangel-02 liangel-02 force-pushed the final branch 6 times, most recently from bd8782d to e6b8403 Compare September 29, 2025 14:00
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good! I recommend comparing the commit counts per category output from merge.py against the expected number in each category to make sure nothing was left out here, or at least spot check a few of them.

It looks like there may be some missing BC-breaking / deprecation notes; I think that's worth looking into.

Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to change out all the links for shorter links to PRs

@liangel-02 liangel-02 force-pushed the final branch 5 times, most recently from 9332fee to ea038a1 Compare September 29, 2025 18:50
@liangel-02 liangel-02 force-pushed the final branch 2 times, most recently from 93194b6 to 46868bb Compare September 30, 2025 19:02
Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good!
Only small things about re-ordering to leave the most important parts on top

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants