-
Notifications
You must be signed in to change notification settings - Fork 25
final.md #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
final.md #125
Conversation
bd8782d
to
e6b8403
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good! I recommend comparing the commit counts per category output from merge.py
against the expected number in each category to make sure nothing was left out here, or at least spot check a few of them.
It looks like there may be some missing BC-breaking / deprecation notes; I think that's worth looking into.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to change out all the links for shorter links to PRs
9332fee
to
ea038a1
Compare
93194b6
to
46868bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
Only small things about re-ordering to leave the most important parts on top
No description provided.