Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

Add note about passphrases and ssh-keygen on macOS. #7

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Add note about passphrases and ssh-keygen on macOS. #7

merged 1 commit into from
Jan 14, 2019

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 2, 2019

No description provided.

@dhermes
Copy link
Contributor Author

dhermes commented Jan 2, 2019 •
edited
Loading

FWIW the current code that does the key decryption could be updated to accommodate the BEGIN OPENSSH PRIVATE KEY format.

ParseRawPrivateKeyWithPassphrase in crypto/ssh might do the trick, but seems like it may also run into the same issues with the implementation here.

@dhermes
Copy link
Contributor Author

dhermes commented Jan 14, 2019

@benton Gentle nudge.

benton
benton approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@benton benton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@benton benton merged commit d96cf4c into mdsol:master Jan 14, 2019
@dhermes
Copy link
Contributor Author

dhermes commented Jan 14, 2019

Thank you for this great tool. Cheers!

@dhermes dhermes deleted the patch-1 branch January 14, 2019 18:53
@dhermes dhermes mentioned this pull request Jan 17, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@benton benton benton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhermes @benton