fix some clippy warnings #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clippy::clone_on_copy - clippy::let_and_return - clippy::needless_borrow - clippy::needless_return - clippy::option_map_unit_fn - clippy::redundant_locals - clippy::single_match - clippy::unnecessary_lazy_evaluations - clippy::useless_format
- clippy::manual_option_map - clippy::match_like_matches_macro - clippy::needless_borrow_for_generic_args - clippy::op_ref - clippy::redundant_closure - clippy::redundant_pattern_matching - clippy::single_char_add_str - clippy::useless_conversion - clippy::writeln_empty_string
- clippy::explicit_auto_deref - clippy::map_clone - clippy::for_kv_map - clippy::match_like_matches_macro
m4rch3n1ng
force-pushed
the
fix-clippy-stuff
branch
from
2eb137e to
7b7e198
Compare
mattwparas
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some miscellaneous fixes / improvements in [f7d4530] and [d0801a9].
and then the clippy fixes are split up into three separate commits for ease of reviewability:
commit [236b1db]:
commit [23937db]:
commit [2eb137e]:
if you prefer, i can split this up into separate prs.
after this change, there are still quite a few clippy lints, specifically those where i wasn't sure what the best course of action was and few that were introduced between clippy 1.82 (the version that master is on) and 1.84 (the version that this fork is on), but it's down from ~80 to only ~20.