Fix test queryer test #1079
Merged
Fix test queryer test #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattn
reviewed
Aug 29, 2022
sqlite3_test.go
Outdated
| n = n + 1 | ||
| } | ||
| if n != 3 { | ||
| if n != 4 { |
There was a problem hiding this comment.
It is a 1-indexed loop, so n is 4 when its looped three times. We could insert 0,1,2 and start at 0 instead, that way n would be 3 when its done. If you prefer that I'll make that change.
There was a problem hiding this comment.
I think it would be more intuitive to have n be the number of rows that were returned, in which case it should start at 0. Whether you change it to insert 0, 1, 2, or change it to compare against n+1 is fine to me.
rittneje
reviewed
Aug 30, 2022
| t.Error("Failed to db.Query: not matched results") | ||
| } | ||
| n = n + 1 | ||
| } |
There was a problem hiding this comment.
Please add the missing call to rows.Err() after the loop.
joshbuddy
force-pushed
the
fix-test-queryer-test
branch
from
9b62e92 to
e830c04
Compare
rittneje
approved these changes
Aug 31, 2022
Open
|
Thank you |
patrickdevivo
referenced
this pull request
in mergestat/mergestat
Oct 26, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/mattn/go-sqlite3](https://togithub.com/mattn/go-sqlite3) | require | patch | `v1.14.15` -> `v1.14.16` | --- ### Release Notes <details> <summary>mattn/go-sqlite3</summary> ### [`v1.14.16`](https://togithub.com/mattn/go-sqlite3/releases/tag/v1.14.16) [Compare Source](https://togithub.com/mattn/go-sqlite3/compare/v1.14.15...v1.14.16) #### What's Changed - Add build tag to enable OSTRACE() logging by [@​benbjohnson](https://togithub.com/benbjohnson) in [https://github.com/mattn/go-sqlite3/pull/1067](https://togithub.com/mattn/go-sqlite3/pull/1067) - TestQueryer: actually check Rows returned by [@​ohwgiles](https://togithub.com/ohwgiles) in [https://github.com/mattn/go-sqlite3/pull/1062](https://togithub.com/mattn/go-sqlite3/pull/1062) - Update README to fix reference URL by [@​shibukawa](https://togithub.com/shibukawa) in [https://github.com/mattn/go-sqlite3/pull/1082](https://togithub.com/mattn/go-sqlite3/pull/1082) - Fix test queryer test by [@​joshbuddy](https://togithub.com/joshbuddy) in [https://github.com/mattn/go-sqlite3/pull/1079](https://togithub.com/mattn/go-sqlite3/pull/1079) - Rollback on constraint failure by [@​joshbuddy](https://togithub.com/joshbuddy) in [https://github.com/mattn/go-sqlite3/pull/1071](https://togithub.com/mattn/go-sqlite3/pull/1071) - Fix "ennviroment" by [@​RewardedIvan](https://togithub.com/RewardedIvan) in [https://github.com/mattn/go-sqlite3/pull/1077](https://togithub.com/mattn/go-sqlite3/pull/1077) - こんにちわ is wrong Japanse, Correct word is こんにちは by [@​KiYugadgeter](https://togithub.com/KiYugadgeter) in [https://github.com/mattn/go-sqlite3/pull/1085](https://togithub.com/mattn/go-sqlite3/pull/1085) - Add test for sqlite_math_functions tag by [@​lggruspe](https://togithub.com/lggruspe) in [https://github.com/mattn/go-sqlite3/pull/1059](https://togithub.com/mattn/go-sqlite3/pull/1059) - remove unuseful ldflags for windows platform. by [@​kkqy](https://togithub.com/kkqy) in [https://github.com/mattn/go-sqlite3/pull/1084](https://togithub.com/mattn/go-sqlite3/pull/1084) - Cross Compiling for Mac OS via `musl-cross` by [@​jodosha](https://togithub.com/jodosha) in [https://github.com/mattn/go-sqlite3/pull/1090](https://togithub.com/mattn/go-sqlite3/pull/1090) - Update README.md to include vtable feature by [@​dvas0004](https://togithub.com/dvas0004) in [https://github.com/mattn/go-sqlite3/pull/1100](https://togithub.com/mattn/go-sqlite3/pull/1100) - Updating vtable example, "BestIndex" method by [@​dvas0004](https://togithub.com/dvas0004) in [https://github.com/mattn/go-sqlite3/pull/1099](https://togithub.com/mattn/go-sqlite3/pull/1099) - Update amalgamation code by [@​mattn](https://togithub.com/mattn) in [https://github.com/mattn/go-sqlite3/pull/1104](https://togithub.com/mattn/go-sqlite3/pull/1104) #### New Contributors - [@​ohwgiles](https://togithub.com/ohwgiles) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1062](https://togithub.com/mattn/go-sqlite3/pull/1062) - [@​shibukawa](https://togithub.com/shibukawa) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1082](https://togithub.com/mattn/go-sqlite3/pull/1082) - [@​joshbuddy](https://togithub.com/joshbuddy) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1079](https://togithub.com/mattn/go-sqlite3/pull/1079) - [@​RewardedIvan](https://togithub.com/RewardedIvan) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1077](https://togithub.com/mattn/go-sqlite3/pull/1077) - [@​KiYugadgeter](https://togithub.com/KiYugadgeter) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1085](https://togithub.com/mattn/go-sqlite3/pull/1085) - [@​lggruspe](https://togithub.com/lggruspe) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1059](https://togithub.com/mattn/go-sqlite3/pull/1059) - [@​kkqy](https://togithub.com/kkqy) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1084](https://togithub.com/mattn/go-sqlite3/pull/1084) - [@​jodosha](https://togithub.com/jodosha) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1090](https://togithub.com/mattn/go-sqlite3/pull/1090) - [@​dvas0004](https://togithub.com/dvas0004) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1100](https://togithub.com/mattn/go-sqlite3/pull/1100) **Full Changelog**: mattn/go-sqlite3@v1.14.15...v1.14.16 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/mergestat/mergestat). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xLjUiLCJ1cGRhdGVkSW5WZXIiOiIzNC4xLjUifQ==-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the TestQueryer test to exec for the multistatement insertion, as well as fixing the value of n