-
Notifications
You must be signed in to change notification settings - Fork 435
Update MPNS to use APNs AuthKey instead of certificates #1476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Newest code from mattermost has been published to preview environment for Git SHA a638f19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Mattermost Push Notification Service (MPNS) documentation to use APNs Auth Keys (.p8) instead of certificates for iOS push notification authentication as part of FIPS compliance efforts.
- Replaces certificate-based iOS authentication with token-based APNs Auth Key authentication
- Updates installation instructions to include FreeBSD support and proper binary naming
- Removes outdated certificate troubleshooting sections and simplifies configuration
Reviewed Changes
Copilot reviewed 2 out of 15 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
site/content/contribute/more-info/mobile/push-notifications/service.md | Updates MPNS configuration from certificate-based to Auth Key authentication, adds FreeBSD support, and removes legacy troubleshooting |
site/content/contribute/more-info/mobile/push-notifications/ios.md | Completely rewrites iOS setup guide to use APNs Auth Keys instead of certificate generation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
`wget https://github.com/mattermost/mattermost-push-proxy/releases/download/vX.X.X/mattermost-push-proxy-linux-amd64.tar.gz` | ||
or | ||
`wget https://github.com/mattermost/mattermost-push-proxy/releases/download/vX.X.X/mattermost-push-proxy-freebsd-amd64.tar.gz` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trailing spaces after the backticks on lines 27 and 29 create unnecessary whitespace in the rendered documentation. Remove the trailing spaces for cleaner formatting.
`wget https://github.com/mattermost/mattermost-push-proxy/releases/download/vX.X.X/mattermost-push-proxy-linux-amd64.tar.gz` | |
or | |
`wget https://github.com/mattermost/mattermost-push-proxy/releases/download/vX.X.X/mattermost-push-proxy-freebsd-amd64.tar.gz` | |
`wget https://github.com/mattermost/mattermost-push-proxy/releases/download/vX.X.X/mattermost-push-proxy-linux-amd64.tar.gz` | |
or | |
`wget https://github.com/mattermost/mattermost-push-proxy/releases/download/vX.X.X/mattermost-push-proxy-freebsd-amd64.tar.gz` |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this on purpose so that it spans to the next line
|
||
3. Unzip the downloaded Mattermost Push Notification Service using: `tar -xvzf mattermost-push-proxy.tar.gz` | ||
3. Unzip the downloaded Mattermost Push Notification Service using: | ||
`tar -xvzf mattermost-push-proxy-linux-amd64.tar.gz` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent trailing spaces after the backticks. Line 36 has two spaces, line 38 has none. Standardize the formatting by removing all trailing spaces for consistency.
`tar -xvzf mattermost-push-proxy-linux-amd64.tar.gz` | |
`tar -xvzf mattermost-push-proxy-linux-amd64.tar.gz` |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
site/content/contribute/more-info/mobile/push-notifications/ios.md
Outdated
Show resolved
Hide resolved
…s.md Co-authored-by: Copilot <[email protected]>
Newest code from mattermost has been published to preview environment for Git SHA e3f44f3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @enahum!
Newest code from mattermost has been published to preview environment for Git SHA 0ccb5ac |
Updates Push Notification Service docs to replace APNs certificate-based configuration with APNs Auth Keys (.p8) as part of Mattermost’s FIPS compliance effort. Android setup and overall structure unchanged.