-
Notifications
You must be signed in to change notification settings - Fork 435
Updates to webhook api #1436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Updates to webhook api #1436
Conversation
- Webhook can now post in threads - Webhook now returns a JSON representation of the message instead of "OK"
Hello @Britaliope, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
@davidkrauser - Assigned you as a member of core reviewers. Feel free to reassign as needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to update the documentation along with your change 🙂
@Britaliope wrote:
Question: Does it makes sense to have the webhook documentation on https://developers.mattermost.com/ ? My first instinct when looking for this documentation was to look on https://api.mattermost.com/
I think what you've done is right - the documentation at api.mattermost.com
specifies the endpoints to create and manage webhooks, while the webhook documentation on developers.mattermost.com
specifies how to use them once created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, pending the related PR merges: mattermost/mattermost#30495
@cwarnermm this introduces a minor breaking change to the API. Instead of returning the plain text ok
, we now return the contents of the post that was created. I know you're working on a new process around breaking changes, so wanted to point it out 🙂
Really appreciate the visibility on this, @davidkrauser! Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for documenting your changes!
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Summary
Documentation MR for mattermost/mattermost#30495
Question: Does it makes sense to have the webhook documentation on https://developers.mattermost.com ? My first instinct when looking for this documentation was to look on https://api.mattermost.com