Skip to content

Conversation

majormer
Copy link
Contributor

Added display_themed_value for TOTAL memory.

Added display_themed_value for TOTAL memory.
@majormer
Copy link
Contributor Author

Added total memory for the sake of displaying current RAM total in the context of used/free. Used can be meaningless if you don't know what the total is. There might be a more elegant way to handle it. If so, please reject and use the correct data source.

@mathoudebine
Copy link
Owner

Thanks for the PR, seems fine to me ! For the CI checks to pass you just need to add your new field to res/themes/default.yaml like it is already done with USED or FREE

Added total entry.
@majormer
Copy link
Contributor Author

Updated default.yaml per your note.

@mathoudebine mathoudebine merged commit f97f5e7 into mathoudebine:main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants