Restore functionality of upload-progress for HTTP2 #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upload-progress module was only getting notified of the first block of uploaded data, because r->read_event_handler was being reset by ngx_http_v2_read_request_body() and ngx_http_v2_process_request_body() The patch detects that situation, updates module_ctx to call the new function, then reinserts itself as the read_event_handler so we continue to be notified about uploaded data. Introduced in nginx/nginx@67d160b Sponsored-by: ScaleEngine Inc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upload-progress module was only getting notified of the first block of uploaded data, because r->read_event_handler was being reset by ngx_http_v2_read_request_body() and
ngx_http_v2_process_request_body()
The patch detects that situation, updates module_ctx to call the new function, then reinserts itself as the read_event_handler so we continue to be notified about uploaded data.
Introduced in nginx/nginx@67d160b
Sponsored-by: ScaleEngine Inc.