Skip to content

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Aug 29, 2025

Problem

The bulk export logic is currently in <BulkExportButton> inside ra-ui-materialui package. That leads to code duplication in other UI packages such as shadcn-admin-kit.

Solution

  • Introduce a useBulkExport hook
  • Use the hook in <BulkExportButton>

How To Test

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)

Also, please make sure to read the contributing guidelines.

@djhi djhi added the RFR Ready For Review label Aug 29, 2025
@slax57 slax57 self-requested a review September 1, 2025 08:29
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that LGTM

@slax57 slax57 added this to the 5.11.0 milestone Sep 1, 2025
@slax57 slax57 merged commit 2781033 into next Sep 1, 2025
15 checks passed
@slax57 slax57 deleted the use-bulk-export branch September 1, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Development

Successfully merging this pull request may close these issues.

2 participants