Skip to content

Add disable support for RadioButtonGroupInput and CheckboxGroupInput choices #10821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 4, 2025
Merged

Add disable support for RadioButtonGroupInput and CheckboxGroupInput choices #10821

merged 12 commits into from
Jul 4, 2025

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Jul 2, 2025 •
edited
Loading

Implements #3677

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

@djhi
Copy link
Collaborator

djhi commented Jul 2, 2025

Thanks! Would you mind adding some tests?

djhi
djhi requested changes Jul 2, 2025
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there 👍

@WiXSL WiXSL requested a review from djhi July 2, 2025 14:15
djhi
djhi requested changes Jul 2, 2025
View reviewed changes
@WiXSL WiXSL changed the title Add disable support for RadioButtonGroupInput choices Add disable support for RadioButtonGroupInput and CheckboxGroupInput choices Jul 2, 2025
@WiXSL WiXSL requested a review from djhi July 2, 2025 16:43
@djhi
Copy link
Collaborator

djhi commented Jul 4, 2025

Thanks!

@djhi djhi added this to the 5.10.0 milestone Jul 4, 2025
@djhi djhi merged commit ccf10db into marmelab:next Jul 4, 2025
12 of 14 checks passed
@WiXSL WiXSL deleted the disable-radiobuttongroupitem-next branch July 4, 2025 11:42
@WiXSL WiXSL mentioned this pull request Jul 7, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
5.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@WiXSL @djhi