WIP: Implicit chaining in lists: Make [x, y,...] same as [(x, y, ...)] #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh hey sorry for letting this get stale :-) the reason for https://github.com/mahmoud/glom/blob/master/glom/core.py#L1861-L1862 the tuple "hides" I'm surprised this doesn't cause some kind of infinite loop, since it causes _handle_tuple to defer over to Pipe, which itself calls back to _handle_tuple: https://github.com/mahmoud/glom/blob/master/glom/core.py#L1885 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #220
There are currently multiple test failures because of #107. I think this demonstrates that the current handling of
SKIPis not optimal, since I would definitely expectglom(target, spec) == glom(target, (spec,)).