Skip to content

Conversation

rbaransii
Copy link

Logical improvement for edit attribute set entity

Description (*)

Pull request contain exception handling for attribute set entity. When controller can't find entity for attribute set, code catch this runtime moment, set relevant moment and redirect to default attribute set page

Manual testing scenarios (*)

Please sign-in to admin panel next go to Stores > Attributes > Attribute Set

  1. Open Default attribute set
  2. Change parameter in url to non existing attribute set eg. 85
  3. You should be redirected to default attribute set page with relevant message
image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Oct 8, 2025

Hi @rbaransii. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@rbaransii
Copy link
Author

@magento run all tests

3 similar comments
@rbaransii
Copy link
Author

@magento run all tests

@rbaransii
Copy link
Author

@magento run all tests

@rbaransii
Copy link
Author

@magento run all tests

@rbaransii
Copy link
Author

@magento run Integration Tests

@rbaransii
Copy link
Author

@magento run Unit Tests

@rbaransii
Copy link
Author

@magento run Functional Tests B2B

@rbaransii
Copy link
Author

@magento run unctional Tests EE

Copy link

Failed to run the builds. Please try to re-run them later.

@rbaransii
Copy link
Author

@magento run functional Tests EE

@rbaransii
Copy link
Author

@magento run functional Tests CE

@rbaransii
Copy link
Author

@magento run Static Tests

@rbaransii
Copy link
Author

@magento run WebAPI Tests

@rbaransii
Copy link
Author

@magento run Functional Tests B2B

@rbaransii
Copy link
Author

@magento run Sample Data Tests EE

Copy link

Failed to run the builds. Please try to re-run them later.

@rbaransii
Copy link
Author

@magento run Sample Data Tests CE

Copy link

Failed to run the builds. Please try to re-run them later.

@rbaransii
Copy link
Author

@magento run Sample Data Tests B2B

Copy link

Failed to run the builds. Please try to re-run them later.

@rbaransii
Copy link
Author

@magento run Functional Tests B2B

@rbaransii
Copy link
Author

@magento run Functional Tests EE

@rbaransii
Copy link
Author

@magento run Functional Tests CE

1 similar comment
@rbaransii
Copy link
Author

@magento run Functional Tests CE

@rbaransii
Copy link
Author

@magento run Functional Tests EE

1 similar comment
@rbaransii
Copy link
Author

@magento run Functional Tests EE

@rbaransii
Copy link
Author

@magento run Functional Tests CE

@rbaransii
Copy link
Author

@magento run Functional Tests B2B

@rbaransii
Copy link
Author

@magento run Functional Tests CE

@rbaransii
Copy link
Author

@magento run Functional Tests B2B

@rbaransii
Copy link
Author

@magento run Functional Tests CE

@rbaransii
Copy link
Author

@magento run Functional Tests EE

@rbaransii
Copy link
Author

@magento run Functional Tests B2B

@rbaransii
Copy link
Author

@magento run Functional Tests CE

@rbaransii
Copy link
Author

@magento run Functional Tests EE

@rbaransii
Copy link
Author

@botName assign @magento-engcom-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant