Skip to content

Conversation

sanadhis
Copy link
Contributor

@sanadhis sanadhis commented Oct 8, 2025

BUG FIX
Without specifying : we tell getopt this option doesn't need a value, hence breaking the script:

getopt: option `--header-length' doesn't allow an argument

Example use-case from infra repo:
https://github.com/lumapps/infra/blob/master/.pre-commit-config.yaml#L107

NOTE
You might experience this only with recent version of getopt (especially if you're MacOS user and install the newer version)

@sanadhis sanadhis requested review from a team and lumautomation as code owners October 8, 2025 07:21
Copy link

@noirbee noirbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:tink: How did this never come up before ? Is the =100 from the infra repository ignored ?

@sanadhis
Copy link
Contributor Author

sanadhis commented Oct 8, 2025

:tink: How did this never come up before ? Is the =100 from the infra repository ignored ?

I cannot really answer why 😖
One thing coming to mind is the version of getops, I have MacOS machine and just recently installed the latest version

@sanadhis
Copy link
Contributor Author

sanadhis commented Oct 8, 2025

@noirbee can you merge this for me pretty please? I can't because of the checks but not sure why the check is failing.

@noirbee
Copy link

noirbee commented Oct 8, 2025

@noirbee can you merge this for me pretty please? I can't because of the checks but not sure why the check is failing.

Sigh, it's the public vs private repository for actions failure again.

@prousso what's our status here ? Do we need to switch this repo to be a private one ?

@prousso
Copy link
Contributor

prousso commented Oct 8, 2025

I think we use it in many public repositories...
We will remove required check for github-actions-validator temporarily

@prousso
Copy link
Contributor

prousso commented Oct 8, 2025

https://github.com/lumapps/github-automation/pull/2173

@sanadhis sanadhis merged commit 7d10d20 into master Oct 8, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants