Ending slash is output for pattern without ending slash

[TrySound]

Hi! I decided to build own router and stuck on small mismatch with path-to-regexp behaviour.

I expect /:page matching /dashboard/activities do not include slash in the end of dashboard in exec array.
https://codesandbox.io/s/intelligent-fermat-mwv42

[lukeed]

Hey, I'll have to look at this carefully as this library is also the basis of Polka and a few other big projects. I think I can make a change without affecting anything too much (including performance), but may I ask why you're using results[0]? It's generally always the [1] result and onwards that are cared about, since those are the groups.

In that regard, there's no difference. Both are "clean" dashboard value

[TrySound]

results[0] is matched url. I use it in a few places in my project.
https://github.com/ReactTraining/react-router/blob/master/packages/react-router/modules/matchPath.js#L48

[lukeed]

Right, fair enough :) I will investigate and update here later tonight or tomorrow. I already have it working/solved locally, but I have to examine the impact & ensure nothing else is adversely affected

[TrySound]

Great! Thanks!

[lukeed]

Perhaps you knew this, but ptr doesn't always trim the trailing slash: https://codesandbox.io/s/thirsty-hopper-swxme

Just wanted to highlight that clarification while I was looking into behavioral differences

[TrySound]

I did not know. Though I don't see difference in your codesandbox. Did you save it?

[lukeed]

Oops, try now

[TrySound]

I see. I think this is ok. In my app there is usually only root trailing slash which is handled separately. But I'm good if it's easier for you to consider this case too.

[lukeed]

Do you need loose mode? Without loose, the trailing is always stripped.

[TrySound]

Yes, I use match only loosely. For example on page /dashboard I open modal with item /dashboard/id. And modal uses own matcher for this.

[lukeed]

Understood, just making sure.

I still have to investigate some dependents, but I just pushed the code (and way more tests) to #6

I have to step out for a little bit, but if you can verify that that PR behaves as expected, would be appreciated. Back soon 👍