Add a get started button to the top nav #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying localstack-docs with
|
| Latest commit: |
8ca609c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://78af914f.localstack-docs.pages.dev |
| Branch Preview URL: | https://get-started-button.localstack-docs.pages.dev |
|
Tested it and it looks great! It seems to work on the AWS side, but the Snow seems to have a tiny issue... even tho initially it appends the snow parameter to the URL, it quickly disappears and doesn't seem to work in the final load? |
Comment on lines
6
to
11
| const isSnowflakePage = route.id.startsWith('snowflake'); | ||
|
|
||
| // Build the URL with conditional parameter | ||
| const getStartedUrl = isSnowflakePage | ||
| ? 'https://app.localstack.cloud/sign-up?emulator=snowflake' | ||
| : 'https://app.localstack.cloud/sign-up'; |
There was a problem hiding this comment.
Suggested change
| const isSnowflakePage = route.id.startsWith('snowflake'); | |
| // Build the URL with conditional parameter | |
| const getStartedUrl = isSnowflakePage | |
| ? 'https://app.localstack.cloud/sign-up?emulator=snowflake' | |
| : 'https://app.localstack.cloud/sign-up'; | |
| const isSnowflakePage = route.id.startsWith('snowflake'); | |
| // Build the URL with conditional parameter | |
| const getStartedUrl = isSnowflakePage | |
| ? 'https://app.localstack.cloud/sign-up?emulator=snowflake' | |
| : 'https://app.localstack.cloud/sign-up'; |
In this case, should we remove these lines @remotesynth ?
There was a problem hiding this comment.
I tweaked the lines but left them in. The URL variable doesn't really do anything it seems at the moment but I think it's worth differentiating which docs they came from anyway.
It was confusing that there is a Getting Started and a Get Started. I didn't want people to think this led to a docs page. Also cleaned up the code a bit. Left the emulator tag in although it doesn't do anything at the moment.
quetzalliwrites
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a get started button to the top navigation to encourage sign ups. This links to
https://app.localstack.cloud/sign-up. If you are in the snowflake docs, it will add an?emulator=snowflakeas is done in the web site.