chore: remove CRA and move to a pure esbuild build #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
react-scripts is deprecated and its dependencies are a source of vulnerabilties. This moves the build to a pure esbuild more in line with other projects.
Pive01
reviewed
Oct 2, 2025
There was a problem hiding this comment.
To work it works as I could build the image and install it in docker desktop successfully.
I've left a few comments on things that I don't think we actually need but didn't verify all the packages changes one by one, which is where I trust your judgment. Let me know if you want me to go over the comments and address them or you wish to do it yourself :)
| "esbuild": "^0.19.12", | ||
| "esbuild-plugin-clean": "^1.0.1", | ||
| "esbuild-plugin-svgr": "^1.0.0", | ||
| "eslint": "^8.57.0", |
There was a problem hiding this comment.
Seems like this eslint version is not compatible with the TS version we are using
Comment on lines
28
to
+55
| "eslintConfig": { | ||
| "extends": [ | ||
| "react-app", | ||
| "react-app/jest" | ||
| ] | ||
| "airbnb", | ||
| "airbnb/hooks", | ||
| "plugin:@typescript-eslint/recommended", | ||
| "plugin:jsx-a11y/recommended", | ||
| "plugin:react/jsx-runtime", | ||
| "prettier" | ||
| ], | ||
| "parser": "@typescript-eslint/parser", | ||
| "parserOptions": { | ||
| "sourceType": "module", | ||
| "ecmaVersion": "latest", | ||
| "project": "./tsconfig.json" | ||
| }, | ||
| "plugins": [ | ||
| "@typescript-eslint" | ||
| ], | ||
| "settings": { | ||
| "import/resolver": { | ||
| "node": { | ||
| "extensions": [ | ||
| ".js", | ||
| ".jsx", | ||
| ".ts", | ||
| ".tsx" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
II'm pretty sure most of these are not needed as we already specify in the .eslintrc.js file
| "@typescript-eslint/eslint-plugin": "^5.38.1", | ||
| "eslint": "^8.24.0", | ||
| "@esbuild-plugins/node-modules-polyfill": "^0.1.4", | ||
| "@playwright/test": "^1.38.0", |
There was a problem hiding this comment.
Do we want to add this? Given there are no tests atm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
react-scripts is deprecated and its dependencies are a source of vulnerabilities. This PR moves the build to a pure esbuild more in line with other projects. After this change, npm audit goes from 29 vulnerabilities to just 2.
public/ assets into build/
Tested:
Caveats / Follow-ups
Disclaimer: Codex agent helped heavily here