Skip to content

Conversation

rkayaith
Copy link
Member

@rkayaith rkayaith commented Sep 9, 2025

Using ConversionPatternRewriter::replaceAllUsesWith + ConversionPatternRewriter::eraseOp is not supported at the moment, and will fail an assert after integrating llvm/llvm-project@2929a29.

The workaround is to use replaceOp instead, see: llvm/llvm-project#155244 (comment)

Copy link
Collaborator

@penguin-wwy penguin-wwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjgarvey zjgarvey merged commit 7000187 into main Sep 10, 2025
3 checks passed
@zjgarvey zjgarvey deleted the users/rkayaith/reduce-variants-op-erase branch September 10, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants